Repository navigation
fix(vscode): show every namespace as selected when the selection is empty - #3521
Merged
rocketstack-matt merged 3 commits intoOct 27, 2026
Merged
rocketstack-matt merged 3 commits into
rocketstack-matt merged 3 commits into
Conversation
…mpty Hovering the CALM Hub status bar item with `calm.hub.selectedNamespaces` empty or unset reported "0 selected" and marked every namespace with ○, even though an empty selection means "all namespaces" everywhere else. That rule was written inline in CanvasPanel.sendAssets(). It now lives in resolveSelectedNamespaces(), which the canvas panel and the status bar both call, so the two cannot drift apart again. The status bar text is unchanged: an empty selection still shows (N). Fixes finos#3493
rocketstack-matt
requested changes
Oct 27, 2026
rocketstack-matt
left a comment
Member
There was a problem hiding this comment.
Thank you for your first contribution to CALM.
The osv-scanner failure is not caused by this PR. It comes from a new advisory against block-buffer in the calm-studio Cargo.lock. I will fix it separately.
Review feedback on finos#3521: CALM Hub has no namespace selection of its own — the filter is the plugin's `calm.hub.selectedNamespaces` setting — and listing the callers in a docstring goes stale. The comment now names the setting instead. Refs finos#3493
Contributor
Author
|
Updated at The docstring now names the |
rocketstack-matt
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With
calm.hub.selectedNamespacesempty or unset, the canvas palette shows every namespace, but the status bar tooltip reportedNamespaces (0 selected / 2 available)and marked each namespace with○.The "empty selection means all namespaces" rule was written inline in
CanvasPanel.sendAssets()and never reachedHubStatusBar. It now lives in one function that both call:CanvasPanel.sendAssets()keeps its behaviour and loses the inline conditional.HubStatusBaruses the resolved list for the tooltip's count and the✓/○marks.(N), as the issue notes it was already correct.extension.tsreads the same setting in the namespace quick pick, but that is the write path (it stores the user's choice), not the render-time rule, so it is untouched.Closes #3493
Type of Change
Affected Components
calm-plugins/vscode/)Commit Message Format ✅
fix(vscode): show every namespace as selected when the selection is emptyTesting
The new status bar test fails on the unpatched code with exactly the reported symptom:
With the change:
The function tests cover the empty/
undefined/nullcases, a subset selection, names the hub no longer lists, and an empty hub list.npx tsc -p tsconfig.extension.json --noEmitreports the same two errors asmain(hub-client.ts:108,generic-svg-parser.ts:1— the second is a missing@typespackage in my filtered install), so this diff adds no type errors.