Repository navigation
fix(calm-hub-ui): stop navbar actions covering the logo on narrow screens - #3517
Merged
rocketstack-matt merged 2 commits intoOct 27, 2026
Merged
Conversation
…eens Below lg the logo is now in the flex flow between two flex-1 side groups, so the View button pushes it aside instead of covering it. Desktop keeps the absolute centring. Closes finos#3505
rocketstack-matt
requested changes
Oct 27, 2026
rocketstack-matt
left a comment
rocketstack-matt
left a comment
Member
There was a problem hiding this comment.
With OIDC on, View still covers the logo at 375px and narrower. See the navbar-end comment.
rocketstack-matt
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #3505.
On narrow screens the diagram View button covered the CALM logo. The logo was absolutely centred, so it took no space in the navbar row. The overlap was 6px at 390px and 41px at 320px. With an environment pill, the logo also covered the pill.
Below
lg, the logo is now in the flex flow between twoflex-1side groups. The sides cannot shrink under their content, so:object-contain, so it keeps its aspect ratio.At
lgand above, the layout does not change. The logo keeps the absolute centring.Type of Change
Affected Components
cli/)calm/)calm-ai/)calm-hub/)calm-hub-ui/)calm-lab/)calm-models/)calm-server/)calm-studio/)calm-widgets/)calm-guard/)docs/)shared/)calm-plugins/vscode/)Commit Message Format ✅
Testing
I measured the navbar in Chromium (Playwright, Vite dev server) at 320–1280px, with and without an environment pill. The View button was a copy of the
DiagramSectionmarkup in#navbar-actions. jsdom does no layout, so the new unit tests check only the layout classes.Checklist