-
Notifications
You must be signed in to change notification settings - Fork 47
fix(pattern): correct cross-chain atomicity claims in ERC-7573 cards #198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
oskarth
wants to merge
1
commit into
master
Choose a base branch
from
fix/erc7573-atomicity-claims
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -4,7 +4,7 @@ status: ready | |||||
| maturity: testnet | ||||||
| type: standard | ||||||
| layer: offchain | ||||||
| last_reviewed: 2026-06-18 | ||||||
| last_reviewed: 2026-09-11 | ||||||
|
|
||||||
| works-best-when: | ||||||
| - Multiple financial institutions each operate their own permissioned ledger but require atomic cross-ledger settlement. | ||||||
|
|
@@ -81,16 +81,16 @@ Enable atomic transactions and data exchange across distinct permissioned ledger | |||||
|
|
||||||
| Guarantees: | ||||||
|
|
||||||
| - Atomicity: cross-ledger operations settle consistently or abort. | ||||||
| - Atomicity, assuming an honest coordinator: cross-ledger operations settle consistently or abort. | ||||||
| - Counterparty privacy: only transacting parties see payload state; other domains observe only commitment envelopes. | ||||||
| - Regulatory audit: scoped access for supervisory entities via dedicated disclosure paths. | ||||||
|
|
||||||
| Threat model: | ||||||
|
|
||||||
| - Honesty of the sync coordinator or relayer set. A malicious coordinator can stall commits but cannot unilaterally fabricate state. | ||||||
| - Honesty of the sync coordinator or relayer set. A crashed coordinator blocks domains that have already prepared. A malicious one can send different decisions to different domains, breaking atomicity, unless a Byzantine fault tolerant commit protocol prevents conflicting decisions. | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| - Each domain's local consensus. A compromised domain can produce inconsistent views to counterparties. | ||||||
| - Operator control over admission. Each ledger operator retains the ability to deny access, freeze assets, or refuse to process transactions within its domain. | ||||||
| - Cross-chain atomicity under partition is out of scope for simple two-phase commit; stronger protocols are needed when domains lose connectivity mid-commit. | ||||||
| - Partitions. Two-phase commit keeps atomicity during a partition by blocking: prepared domains wait until they reconnect. Non-blocking commit needs stronger protocols. | ||||||
|
|
||||||
| ## Trade-offs | ||||||
|
|
||||||
|
|
||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mentioned below