Skip to content

fix: escaped parentheses in nested labels in no-reversed-media-syntax #752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lumirlumir wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: escaped parentheses in nested labels in no-reversed-media-syntax #752

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/rules/no-reversed-media-syntax.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,11 @@

/**
* Matches reversed link/image syntax like `(text)[url]`, ignoring escaped characters like `\(text\)[url]`.
* The nested group is `\([^()]*\)`, not `\([\s\S]*\)`, so that it cannot overlap the
* The nested group is `\((?:\\[\s\S]|[^()\\])*\)`, not `\([\s\S]*\)`, so that it cannot overlap the
* other alternatives. Overlapping alternatives cause catastrophic backtracking.
*/
const reversedPattern =
/(?<=(?<!\\)(?:\\{2})*)\((?<label>(?:\\.|[^()\\]|\([^()]*\))*)\)\[(?<url>(?:\\.|[^\]\\\r\n])*)\](?!\()/gu;
/(?<=(?<!\\)(?:\\{2})*)\((?<label>(?:\\.|[^()\\]|\((?:\\[\s\S]|[^()\\])*\))*)\)\[(?<url>(?:\\.|[^\]\\\r\n])*)\](?!\()/gu;

//-----------------------------------------------------------------------------
// Rule Definition
Expand Down
131 changes: 131 additions & 0 deletions tests/rules/no-reversed-media-syntax.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -588,6 +588,137 @@ ruleTester.run("no-reversed-media-syntax", rule, {
},
],
},
// Nested parentheses with escaped characters
{
code: "(a (b \\(c\\)) d)[x]",
output: "[a (b \\(c\\)) d](x)",
errors: [
{
messageId: "reversedSyntax",
line: 1,
column: 1,
endLine: 1,
endColumn: 19,
},
],
},
{
code: "!(a (b \\(c\\)) d)[x]",
output: "![a (b \\(c\\)) d](x)",
errors: [
{
messageId: "reversedSyntax",
line: 1,
column: 2,
endLine: 1,
endColumn: 20,
},
],
},
{
code: "(a (b\\( c))[x]",
output: "[a (b\\( c)](x)",
errors: [
{
messageId: "reversedSyntax",
line: 1,
column: 1,
endLine: 1,
endColumn: 15,
},
],
},
{
code: "!(a (b\\( c))[x]",
output: "![a (b\\( c)](x)",
errors: [
{
messageId: "reversedSyntax",
line: 1,
column: 2,
endLine: 1,
endColumn: 16,
},
],
},
{
code: "(a (b\\) c))[x]",
output: "[a (b\\) c)](x)",
errors: [
{
messageId: "reversedSyntax",
line: 1,
column: 1,
endLine: 1,
endColumn: 15,
},
],
},
{
code: "!(a (b\\) c))[x]",
output: "![a (b\\) c)](x)",
errors: [
{
messageId: "reversedSyntax",
line: 1,
column: 2,
endLine: 1,
endColumn: 16,
},
],
},
{
code: "(a (b\\\\) c)[x]",
output: "[a (b\\\\) c](x)",
errors: [
{
messageId: "reversedSyntax",
line: 1,
column: 1,
endLine: 1,
endColumn: 15,
},
],
},
{
code: "!(a (b\\\\) c)[x]",
output: "![a (b\\\\) c](x)",
errors: [
{
messageId: "reversedSyntax",
line: 1,
column: 2,
endLine: 1,
endColumn: 16,
},
],
},
{
code: "(a (b\\\nc))[x]",
output: "[a (b\\\nc)](x)",
errors: [
{
messageId: "reversedSyntax",
line: 1,
column: 1,
endLine: 2,
endColumn: 7,
},
],
},
{
code: "!(a (b\\\nc))[x]",
output: "![a (b\\\nc)](x)",
errors: [
{
messageId: "reversedSyntax",
line: 1,
column: 2,
endLine: 2,
endColumn: 7,
},
],
},
// Heading
{
code: "# (ESLint)[https://eslint.org/]",
Expand Down
Loading