Repository navigation
fix: escaped parentheses in nested labels in no-reversed-media-syntax - #752
lumirlumir wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe reversed media pattern now supports nested parentheses and escaped characters in labels. Tests cover reversed links and images with these label forms and verify conversion and error ranges. ChangesReversed media syntax
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The targeted reversed-syntax cases are covered, and no actionable merge risk remains beyond normal checks. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Prerequisites checklist
AI acknowledgment
What is the purpose of this pull request?
Environment
Which language are you using?
commonmark and gfm
What did you do?
Linted the following Markdown:
What did you expect to happen?
The rule should report reversed syntax and autofix it to:
What actually happened?
No problems were reported.
What changes did you make? (Give an overview)
Fixes a regression introduced in #693 that was overlooked during review. I found it while reviewing #736 (comment), thanks to a comment from CodeRabbit.
The limitation introduced in #693 was that parentheses nested two or more levels deep were no longer reported. However, escaped parentheses should still be reported because they don’t create nested parentheses.
I’ve looked into this carefully, and this change does not introduce any ReDoS-related regressions. The newly added
[\s\S]pattern does not cause catastrophic time complexity.Related Issues
#693
Is there anything you'd like reviewers to focus on?
N/A
Summary by CodeRabbit