Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Darling/Darling.Tests/DarlingPeerDisclosureTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -382,7 +382,7 @@ private static JsonElement RenderedServerList(DarlingPeerDirectory.Snapshot peer
{
var rows = new List<DarlingDataReader.ServerListRow>
{
new(1, "prod-sql-use1-beta-01", "ayr", 16, new DateTime(2026, 8, 19, 12, 0, 0, DateTimeKind.Utc)),
new(1, "prod-sql-use1-beta-01", "omega", 16, new DateTime(2026, 8, 19, 12, 0, 0, DateTimeKind.Utc)),
};

return JsonDocument
Expand Down Expand Up @@ -410,7 +410,7 @@ public void ListServers_CarriesThePeerFleetsSummary()
/* The existing payload is untouched — the disclosure is additive here too. */
var server = Assert.Single(root.GetProperty("servers").EnumerateArray());
Assert.Equal("prod-sql-use1-beta-01", server.GetProperty("server_name").GetString());
Assert.Equal("ayr", server.GetProperty("display_name").GetString());
Assert.Equal("omega", server.GetProperty("display_name").GetString());
}

[Fact]
Expand Down
2 changes: 1 addition & 1 deletion Darling/Darling.Tests/StatementSplitTimingTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ public void EveryPhaseAccountedFor_ThePartsNeverExceedTheWhole()

/// <summary>
/// #2312: the separate plan-XML and text fetches run INSIDE the driver's <c>sql:</c> stopwatch but are
/// their own queries against the Query Store catalogs — on ayr-01 a 0-row closed-only cycle still cost
/// their own queries against the Query Store catalogs — on omega-01 a 0-row closed-only cycle still cost
/// 298s and the blended number could not say where. They must come out of drain exactly like the
/// watermark phase, or drain silently absorbs the one cost this investigation needs isolated.
/// </summary>
Expand Down
2 changes: 1 addition & 1 deletion PerformanceMonitor.Collectors/CollectorContext.cs
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,7 @@ public sealed class CollectorContext
/// runs one (Darling; Lite has no separate fetch and leaves it zero). The fetch is INSIDE the driver's
/// per-item <c>sql:</c> stopwatch but is neither open nor drain — it is its own query against
/// <c>sys.query_store_plan</c>, and on a database with a huge Query Store catalog it can dominate the
/// whole item (ayr-01: a 0-row closed-only cycle still cost 298s, and the blended number could not say
/// whole item (omega-01: a 0-row closed-only cycle still cost 298s, and the blended number could not say
/// where). Measured so drain stops absorbing it, exactly the #2164 argument one seam further down.
/// </summary>
public long PerItemPlanFetchMs { get; set; }
Expand Down
Loading