Scrub the last fleet identifier from main - #2912
erikdarlingdata wants to merge 1 commit into
Conversation
`main` is the repo's default branch and is swept separately from `dev` — the two have divergent history, so the scrubs merged to dev (#2900, #2903) never reached it. Four locations still named a real tenant server. Uses `omega`, the slug #2900 reconciled this server onto, so the name is consistent with dev and is already allowlisted in `FleetIdentifierScrubTests.SyntheticSlugs`. Same precedent as 26a4e14. Line endings preserved per file. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Reviewed. This is a pure identifier scrub —
No correctness, security, or performance concerns. LGTM. |
|
Closing. This can't land as shaped — It also isn't needed. The equivalent changes are already on The verification work here was sound and the slug choice was right (matching what #2900 reconciled to, rather than picking fresh). Nothing wrong with the change itself — just the branch it targeted. |
mainis the repo's default branch and is swept separately fromdev. The two have genuinely divergent history, so the identifier scrubs merged to dev ([#2900], [#2903]) never reached it — four locations onmainstill named a real tenant server.What changed
Darling.Tests/DarlingPeerDisclosureTests.cs:385display_namefixtureomegaDarling.Tests/DarlingPeerDisclosureTests.cs:413omegaDarling.Tests/StatementSplitTimingTests.cs:79omega-01PerformanceMonitor.Collectors/CollectorContext.cs:253omega-01omegais not a fresh choice — it is the slug [#2900] reconciled this server onto, it is already inFleetIdentifierScrubTests.SyntheticSlugs, and these four lines now matchorigin/devbyte-for-byte (verified by diffing slug usage per file). Every measurement in the touched comments is unchanged.Line endings preserved per file (CRLF counts asserted before/after).
Same precedent as 26a4e14, "Scrub fleet identifiers from main, which is what the repo shows by default".
Why a PR and not a direct commit
26a4e14 went straight onto
main. This is the same change shape, but a PR leaves the diff reviewable and revertable, and there is no rush now that the issue/PR-body exposure is closed.🤖 Generated with Claude Code