Skip to content

fix(codec): bound HELLO locator count by remaining bytes #1237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
evshary wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(codec): bound HELLO locator count by remaining bytes #1237

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/protocol/codec/message.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,10 @@ z_result_t _z_locators_decode_na(_z_locator_array_t *a_loc, _z_zbuf_t *zbf) {
_z_zint_t len = 0; // Number of elements in the array
ret |= _z_zsize_decode(&len, zbf);
if (ret == _Z_RES_OK) {
// Each locator requires at least one byte on the wire for the string length.
if (len > _z_zbuf_len(zbf)) {
_Z_ERROR_RETURN(_Z_ERR_MESSAGE_DESERIALIZATION_FAILED);
}
*a_loc = _z_locator_array_make(len);

// Decode the elements
Expand Down
Loading