fix(codec): bound HELLO locator count by remaining bytes - #1237
Open
evshary wants to merge 1 commit into
Open
Conversation
Signed-off-by: ChenYing Kuo <evshary@gmail.com>
14 tasks
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR makes
HELLOlocator decoding reject impossible locator counts before allocating memory. It turns malformed locator lists into normal deserialization failures instead of very large allocation attempts.What does this PR do?
HELLOlocator lists before allocating the locator array.Why is this change needed?
Before this change, a malformed
HELLOmessage could decode a huge locator count and try to allocate an extremely large locator array. This PR adds a simple bounds check based on the remaining input bytes so invalid messages fail cleanly and safely.Related Issues
eclipse-zenoh/zenoh#2592
🏷️ Label-Based Checklist
Based on the labels applied to this PR, please complete these additional requirements:
Labels:
bug🐛 Bug Fix Requirements
Since this PR is labeled as a bug fix, please ensure:
Why this matters: Bugs without tests often reoccur.
Instructions:
- [ ]to- [x])This checklist updates automatically when labels change, but preserves your checked boxes.