Skip to content

ConfigUtilities.ParseTimeSpan overflows too easily: use double instead of int #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gabikliot merged 1 commit into from
Jan 23, 2015
Merged

ConfigUtilities.ParseTimeSpan overflows too easily: use double instead of int #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Orleans/Configuration/ConfigUtilities.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,8 +311,8 @@ internal static TimeSpan ParseTimeSpan(string input, string errorMessage)
unitSize = 1000; // Default is seconds
numberInput = trimmedInput;
}
int rawTimeSpan;
if (!Int32.TryParse(numberInput, out rawTimeSpan))
double rawTimeSpan;
if (!double.TryParse(numberInput, out rawTimeSpan))
{
throw new FormatException(errorMessage + ". Tried to parse " + input);
}
Expand Down