ConfigUtilities.ParseTimeSpan overflows too easily: use double instead of int - #4
Merged
Conversation
…or numeric overflows.
sergeybykov
pushed a commit
that referenced
this pull request
Oct 20, 2015
Make ClusterConfiguration.ResolveIPAddress() asynchronous.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, ConfigUtilities.ParseTimeSpan parses values into a string before multiplying them into milliseconds and passing them into TimeSpan.FromMilliseconds, which expects a double.
Multiplying the parsed value into milliseconds can cause it to overflow, resulting in a negative TimeSpan.
By parsing directly into double, these overflows can be largely avoided.