Repository navigation
fix(prefs): show the work profile badge in app pickers - #44
Merged
Merged
Conversation
Hidden apps, Dismissed predictions, the gesture app picker, drawer-folder app selection and the folder-widget picker drew BitmapInfo.icon, the bare icon. Launcher3 keeps the work/clone/private badge as a flag and only draws it through BitmapInfo.newIcon(), so a work app looked identical to the personal copy in those lists. App now keeps the badged drawable and AppItem draws it with a drawable painter, which also avoids copying the hardware bitmaps. ISS-20261020-03 (point 2) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
denson9874
marked this pull request as ready for review
November 1, 2026 01:39
This was referenced Nov 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Daryl
Description
Work, clone and private-space apps in the preference app pickers now show the same profile badge as Home and search. That covers Hidden apps, Dismissed predictions, the gesture "open app" picker, drawer-folder app selection and the folder-widget app picker. Before, the work copy of an app looked identical to the personal one. This is point 2 of Pratik's report (ISS-20261020-03).
Reasoning
App(AppsList.kt) keptappInfo.bitmap.icon, the bare bitmap. Launcher3 never bakes the badge into that bitmap: it lives inBitmapInfo.flags(FLAG_WORK and the others) and is drawn only byBitmapInfo.newIcon(), which returns a FastBitmapDrawable with a UserBadgeDrawable.App.iconis nowappInfo.bitmap.newIcon(context).AppItemdraws it with accompanist'srememberDrawablePainter, which the project already uses.newIcon().toBitmap()was avoided on purpose. Cached icons are hardware bitmaps, and copying them would hold roughly 150 KB per app.AppItem(label, Bitmap, …)overload still works; it now forwards to a newPainteroverload, soSelectIconPreferenceis unchanged.bitmap.newIcon, notItemInfoWithIcon.newIcon).The other points of the report are not in this PR:
4_by_6both use a 65 dp base, so 90% is 58.5 dp in both places. It needs Pratik's device and a dumpsys.Testing
./gradlew testLawnWithQuickstepExpressiveDebugUnitTest: 650/650 pass, and the Expressive debug variant compiles.App.icon.Type of change
✅ Bug fix (A non-breaking change that fixes an issue)
❌ New feature (A non-breaking change that adds functionality)
❌ Breaking change (A fix or feature that would cause existing functionality to not work as expected)
❌ Refactor (A code change that neither fixes a bug nor adds a feature)
❌ Performance (A code change that improves performance)
❌ Style (Code style changes)
❌ Docs (Changes to documentation)
❌ Chore (Changes to the build process or other tooling)
🤖 Generated with Claude Code