Repository navigation
Runtime fixes 3/5: Schedule diagnostics by elapsed time - #433
Merged
guido4096 merged 2 commits intoNov 1, 2026
Merged
Conversation
This was referenced Oct 31, 2026
guido4096
marked this pull request as ready for review
October 31, 2026 19:31
Throttle heap and socket sampling independently of notification frequency, collect expensive data outside critical sections, and report uptime in seconds. Test sampling and reporting deadlines.
guido4096
force-pushed
the
fix/runtime-monitor-schedule
branch
from
October 31, 2026 20:07
06ac261 to
9a332aa
Compare
yuhu-
approved these changes
Nov 1, 2026
Owner
|
@yuhu- , this was your code, I am not sure we need such massive internal diagnostics at all. |
yuhu-
reviewed
Nov 1, 2026
| @@ -0,0 +1,38 @@ | |||
| // SPDX-License-Identifier: GPL-3.0-or-later | |||
Collaborator
There was a problem hiding this comment.
Have you decided on the GPL-3.0-or-later license? Perhaps we should add the license header to all files in a separate PR.
Owner
There was a problem hiding this comment.
Yes, GPL3 is fine.
If this is the right format, I can have the PR prepared for the rest of the files.
Please confirm.
Collaborator
Yes, we need that; it gives us insight into how the memory has evolved, which is helpful in support cases. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bus/log notifications woke the system monitor and triggered heap/socket collection before its intended interval. Counting these wakes also accelerated the nominally hourly heap trend. Heap inspection and socket collection ran while the status critical section was held, and uptime_seconds contained milliseconds.
Use monotonic deadlines for health sampling every 30 seconds, summaries every five minutes, and heap-trend samples initially and then hourly. Collect heap and socket data outside the critical section and report uptime in seconds. Delayed runs skip missed intervals rather than replaying them.
Validation
Schedule regressions cover frequent notifications, repeated deadline checks, delayed execution and long uptimes.
Device check before marking ready
Verify sampling cadence during sustained eBUS traffic and check that uptime advances in seconds. No on-device reduction in CPU use, latency or instability is claimed from the host tests.
Related runtime fixes
Part 3/5 of the single-commit replacements for #430, split at the maintainer's request. Every PR targets master directly and contains only its corresponding change.
Suggested merge order: the host-test mock fix first, then the other four changes independently. The five patches together reconstruct the exact tracked file tree of #430.
Source commit in #430: 67a5e07.