Repository navigation
Runtime fixes 2/5: Bound Logs page retention - #432
Merged
guido4096 merged 1 commit intoOct 31, 2026
Merged
Conversation
Keep duplicate keys in sync with retained entries and remove only evicted DOM rows. Cover long-running retention, filtering and restart markers.
This was referenced Oct 31, 2026
guido4096
marked this pull request as ready for review
October 31, 2026 19:31
yuhu-
approved these changes
Oct 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a long-running Logs page, duplicate keys remained in seenEntries after their log entries were evicted. Once the retention limit was reached, incoming batches could also trigger rebuilding the complete displayed log.
Keep duplicate keys aligned with retained entries and remove evicted DOM rows incrementally. Preserve filtering, clearing and restart markers. Add a regression that runs the actual page script through repeated retention-limit crossings.
Validation
The regression covers bounded retained keys/entries, incremental row eviction, filtering, clearing and restart markers.
Browser check before marking ready
Leave the Logs page open through repeated crossings of the 2,000-entry limit; verify that new logs, filtering and clearing continue to work and browser memory settles. The host regression is not a browser soak-test result.
Related runtime fixes
Part 2/5 of the single-commit replacements for #430, split at the maintainer's request. Every PR targets master directly and contains only its corresponding change.
Suggested merge order: the host-test mock fix first, then the other four changes independently. The five patches together reconstruct the exact tracked file tree of #430.
Source commit in #430: f552144.