Skip to content

fix(release): keep test model workspace-only #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danieleades merged 2 commits into from
Jul 19, 2026
Merged

fix(release): keep test model workspace-only #118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f7f2dd
fix(release): keep test model workspace-only
danieleades Jul 19, 2026
9e6ec66
fix(ci): address current lints and advisory
danieleades Jul 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ bitstream-io = "4.4.0"
thiserror = { workspace = true }

[dev-dependencies]
fenwick-model = { path = "./fenwick-model", version = "0.1.1" }
fenwick-model = { path = "./fenwick-model" }

@chatgpt-codex-connector chatgpt-codex-connector Bot Jul 19, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Retain fenwick-model for packaged test targets

When Cargo packages this crate, a path-only dev-dependency is omitted from the normalized Cargo.toml; consequently the published crate has no fenwick-model dependency. Its included tests/fuzz.rs, benches/sherlock.rs, and Fenwick examples import that crate, so running cargo test, cargo bench, or building all examples from the unpacked crates.io source will fail to resolve it. Keep a published dependency version or exclude the affected targets from the package.

Useful? React with 👍 / 👎.

criterion = "0.7.0"
test-case = "3.0.0"

Expand Down
1 change: 1 addition & 0 deletions deny.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,5 @@ confidence-threshold = 1.0

[bans]
wildcards = "deny"
allow-wildcard-paths = true
highlight = "all"
4 changes: 2 additions & 2 deletions examples/common/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,12 @@ where
M: Model + Clone,
M::Symbol: std::fmt::Debug,
{
println!("input: {:?}", &input);
println!("input: {input:?}");

println!("\nencoding...");
let buffer = encode(model.clone(), input);

println!("buffer: {:?}", &buffer);
println!("buffer: {buffer:?}");

println!("\ndecoding...");
for symbol in decode(model, &buffer) {
Expand Down
2 changes: 1 addition & 1 deletion examples/concatenated.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ fn main() {

let buffer = encode2(symbolic::Model, &input1, integer::Model, &input2);

println!("\nbuffer: {:?}", &buffer);
println!("\nbuffer: {buffer:?}");

println!("\ndecoding...");
let (output1, output2) = decode2(symbolic::Model, integer::Model, &buffer);
Expand Down
1 change: 1 addition & 0 deletions fenwick-model/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
[package]
name = "fenwick-model"
version = "0.1.1"
publish = false
edition.workspace = true
description = "fenwick-tree-based test utils for the 'arithmetic-coding' crate"
license.workspace = true
Expand Down