Skip to content

fix(release): keep test model workspace-only - #118

Merged
danieleades merged 2 commits into
mainfrom
agent/fix-release-order
Jul 19, 2026
Merged

danieleades merged 2 commits into
mainfrom
agent/fix-release-order

Conversation

@danieleades

Copy link
Copy Markdown
Owner

What changed

  • mark fenwick-model as a workspace-only crate
  • use it as a path-only development dependency from arithmetic-coding

Why

The 0.5.0 release has been stuck since the release PR merged. Release-plz excludes dev-dependencies from its topological publish order (release-plz/release-plz#2697), so it tries to package arithmetic-coding before publishing fenwick-model 0.1.1. Cargo then rejects the package because that dev-dependency version does not exist on crates.io.

fenwick-model is internal test support and does not need an independent public release. Keeping it path-only removes the registry dependency and prevents this ordering bug on future releases.

Merging this PR also provides a fresh push for release-plz to publish the already-prepared arithmetic-coding 0.5.0 release.

Validation

  • cargo test --all-features
  • cargo fmt --all --check
  • cargo package -p arithmetic-coding --allow-dirty

@danieleades
danieleades marked this pull request as ready for review July 19, 2026 12:06
@codecov

codecov Bot commented Jul 19, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.57%. Comparing base (b1501bf) to head (9e6ec66).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #118   +/-   ##
=======================================
  Coverage   87.57%   87.57%           
=======================================
  Files          11       11           
  Lines         483      483           
=======================================
  Hits          423      423           
  Misses         60       60           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8f7f2ddced

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Cargo.toml

[dev-dependencies]
fenwick-model = { path = "./fenwick-model", version = "0.1.1" }
fenwick-model = { path = "./fenwick-model" }

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Retain fenwick-model for packaged test targets

When Cargo packages this crate, a path-only dev-dependency is omitted from the normalized Cargo.toml; consequently the published crate has no fenwick-model dependency. Its included tests/fuzz.rs, benches/sherlock.rs, and Fenwick examples import that crate, so running cargo test, cargo bench, or building all examples from the unpacked crates.io source will fail to resolve it. Keep a published dependency version or exclude the affected targets from the package.

Useful? React with 👍 / 👎.

@danieleades
danieleades merged commit 7aa3b11 into main Jul 19, 2026
12 checks passed
@danieleades
danieleades deleted the agent/fix-release-order branch July 19, 2026 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant