Repository navigation
fix(release): keep test model workspace-only - #118
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #118 +/- ##
=======================================
Coverage 87.57% 87.57%
=======================================
Files 11 11
Lines 483 483
=======================================
Hits 423 423
Misses 60 60 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8f7f2ddced
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| [dev-dependencies] | ||
| fenwick-model = { path = "./fenwick-model", version = "0.1.1" } | ||
| fenwick-model = { path = "./fenwick-model" } |
There was a problem hiding this comment.
Retain fenwick-model for packaged test targets
When Cargo packages this crate, a path-only dev-dependency is omitted from the normalized Cargo.toml; consequently the published crate has no fenwick-model dependency. Its included tests/fuzz.rs, benches/sherlock.rs, and Fenwick examples import that crate, so running cargo test, cargo bench, or building all examples from the unpacked crates.io source will fail to resolve it. Keep a published dependency version or exclude the affected targets from the package.
Useful? React with 👍 / 👎.
What changed
fenwick-modelas a workspace-only cratearithmetic-codingWhy
The 0.5.0 release has been stuck since the release PR merged. Release-plz excludes dev-dependencies from its topological publish order (release-plz/release-plz#2697), so it tries to package
arithmetic-codingbefore publishingfenwick-model0.1.1. Cargo then rejects the package because that dev-dependency version does not exist on crates.io.fenwick-modelis internal test support and does not need an independent public release. Keeping it path-only removes the registry dependency and prevents this ordering bug on future releases.Merging this PR also provides a fresh push for release-plz to publish the already-prepared
arithmetic-coding0.5.0 release.Validation
cargo test --all-featurescargo fmt --all --checkcargo package -p arithmetic-coding --allow-dirty