Repository navigation
[ENG-1888] fix(cmd): replace globby with tinyglobby to drop braces - #469
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
| Topic | Details | |||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| Flow compatibility tests | Verify report conversion and cache flows across relative, absolute, negated, brace, range, empty, and deeply nested patterns, including platform-safe path assertions.Modified files (3)
Latest Contributors(2)
| |||||||||
| Safe glob matching | Replace globby with tinyglobby across convert input discovery and cache path lookup, centralizing matching in globPaths with compatible exclusions, ordering, absolute paths, and numeric-range expansion.Modified files (5)
Latest Contributors(2)
|
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
baz-app
Bot
dismissed
their stale review
October 22, 2026 11:45
Baz withdrew its approval because this pull request is no longer ready to merge.
…Windows paths Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…nges Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…absolute patterns Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
maxigimenez
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
@currents/cmddepends onglobby, which pulls inbraces.braceshas a high-severity advisory (GHSA-vfj7-8cjw-p6xm) with no fixed version, and the latestglobbystill depends on it, so customers' scanners flag cmd.Part of ENG-1888
What changed
globbyis replaced bytinyglobby, which does not usebraces.--input-file(convert,run upload) andcache set(--path,--preset last-run), useglobPaths()insrc/lib/glob.ts. It runstinyglobbyfor each pattern:!patternsare passed to tinyglobby'signore{1..10}are written out as lists. On its own, tinyglobby reads{1..10}as the character class[1-10].braces, andnpm audit --omit=devreports 0 vulnerabilities, down from 5 high.For patterns without
!, the same files are matched as with 2.3.0. The differences:convertkeeps the one it reads last.!patternsapply to every pattern, and one that matches a folder name skips that folder. globby applied them only to the patterns before them, and only to files.EACCES../prefix is dropped from matched paths:./reports/a.xmlcomes back asreports/a.xml.Testing
Steps 2–4 ran on Windows, Linux and macOS, with Node 20, 22 and 24, and with npm, pnpm and yarn installs.
globPaths()rule, including the order and!patternbehavior above.convert,cache setandcache getcommands, with the cache commands against a local mock API.convertandrun uploadof JUnit reports found with--input-file 'reports/**/*.xml'produced the same output.cache set --preset last-runafter a Playwright run with one failing test, thencache geton a second attempt:--last-failedreran only that test.cache set/get --pathrestored the report folder byte for byte.🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.