Repository navigation
sync: write the README upstream badge with the pin, and fail the build when it disagrees - #186
Merged
Merged
Conversation
creedants
added a commit
that referenced
this pull request
Oct 12, 2026
…lure reasons (#194) AGENTS.md lists the reasons the build fails. The README upstream badge check was added to the build in #186, and the list did not mention it. Step 5 of Porting an upstream file now says the build also fails on a README upstream badge that is missing or disagrees with `upstream.json`. How it was checked: the reviewer matched the sentence to the check in `scripts/build.py` and `scripts/check.py` and to its tests. The build and the check pass. Known limits: - This is a document-only change. The full test suite was not run. Reviewed at 629cb2fd.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The upstream version badge in the README can no longer disagree with
upstream.json.scripts/sync_upstream.pyrewrites the badge when it writes a new pin. It changes the two version spans and no other byte, and it keeps the file's line endings.python3 scripts/check.pywith no tree argument, andpython3 scripts/build.py, fail when the badge is missing or names another version. A check of a named outside tree gets no badge finding.Known limits. A prerelease upstream version is refused, not carried. A version string holding a line break prints its refusal on two lines.
Reviewed at de4ea8c5.