Repository navigation
docs: AGENTS.md names the README upstream badge among the build's failure reasons - #194
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AGENTS.md lists the reasons the build fails. The README upstream badge check was added to the build in #186, and the list did not mention it. Step 5 of Porting an upstream file now says the build also fails on a README upstream badge that is missing or disagrees with
upstream.json.How it was checked: the reviewer matched the sentence to the check in
scripts/build.pyandscripts/check.pyand to its tests. The build and the check pass.Known limits:
Reviewed at 629cb2fd.