Add image digest glossary term - #3627
Conversation
✅ Deploy Preview for cncfglossary ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
@caniszczyk kindly review this |
Okabe-Junya
left a comment
There was a problem hiding this comment.
Thank you for your work 👍
left some comments, PTAL when you have time
Okabe-Junya
left a comment
There was a problem hiding this comment.
Looks CI is red - https://github.com/cncf/glossary/actions/runs/23579394564/job/70831152685?pr=3627
Could you also fix this?
|
@VarshaUN would you be willing to update this PR? Maybe do a rebase against main? |
|
Hey @Okabe-Junya , I have adressed you review , kindly check it and lmk! |
Okabe-Junya
left a comment
There was a problem hiding this comment.
Could you check CI error?
Looks some words are missing in wordlist (e.g.. SHA / cryptographic / reproducibility)
|
Hey @Okabe-Junya , I have added the words correctly and CI has failed for unrelated spell check which is not related to my PR , can you help me with this? |
|
Ah, could you rebase? |
|
Ah, 3551 merged w/o CI run, so anyway need to put grpc in wordlist.txt |
|
So would be appreciated if you created another PR to add the word grpc in wordlist and then will rebase this PR |
|
Hey @Okabe-Junya , checkout #3673 |
Signed-off-by: Varsha U N <varshaun58@gmail.com> Signed-off-by: VarshaUN <varshaun58@gmail.com>
Signed-off-by: VarshaUN <varshaun58@gmail.com>
Signed-off-by: VarshaUN <varshaun58@gmail.com>
|
Hey @Okabe-Junya I have rebased and now checks have passed. Kindly review once!! |
nate-double-u
left a comment
There was a problem hiding this comment.
Thanks for this @VarshaUN, could I ask for one more edit before we merged this in?
Updated the image digest documentation to clarify the concept and its importance in security and reproducibility. Signed-off-by: Varsha U N <varshaun58@gmail.com>
nate-double-u
left a comment
There was a problem hiding this comment.
Thanks for the update @VarshaUN, I've integrated it a bit more into that first paragraph, and have done a copy edit pass throughout. Please have a look to make sure I haven't changed your meaning.
Co-authored-by: Nate W <natew@cncf.io> Signed-off-by: Varsha U N <varshaun58@gmail.com>
Co-authored-by: Nate W <natew@cncf.io> Signed-off-by: Varsha U N <varshaun58@gmail.com>
Co-authored-by: Nate W <natew@cncf.io> Signed-off-by: Varsha U N <varshaun58@gmail.com>
Co-authored-by: Nate W <natew@cncf.io> Signed-off-by: Varsha U N <varshaun58@gmail.com>
nate-double-u
left a comment
There was a problem hiding this comment.
Thanks @VarshaUN!
Before we merge this, I'd like to ask @Okabe-Junya to re-review as this has changed a bit since he approved it.
Describe your changes
Related issue number or link (ex:
resolves #issue-number)This PR resolves kubernetes/website#55017
Checklist before opening this PR (put
xin the checkboxes)git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to yourgitconfigby runninggit config --global alias.ci "commit -s".Signed-off-by : Varsha U N varshaun58@gmail.com