Skip to content

fix ice-options grammar #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fippo wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix ice-options grammar #107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/grammar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,9 +243,9 @@ var grammar = module.exports = {
format: 'remote-candidates:%s'
},
{
// a=ice-options:google-ice
// a=ice-options:trickle ice2
name: 'iceOptions',
reg: /^ice-options:(\S*)/,
reg: /^ice-options:(.*)/,
format: 'ice-options:%s'
},
{
Expand Down
2 changes: 1 addition & 1 deletion test/jsep.sdp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ a=rtpmap:98 telephone-event/48000
a=maxptime:120
a=ice-ufrag:ETEn1v9DoTMB9J4r
a=ice-pwd:OtSK0WpNtpUjkY4+86js7ZQl
a=ice-options:trickle
a=ice-options:trickle ice2
a=fingerprint:sha-256 19:E2:1C:3B:4B:9F:81:E6:B8:5C:F4:A5:A8:D8:73:04:BB:05:2F:70:9F:04:A9:0E:05:E9:26:33:E8:70:88:A2
a=setup:actpass
a=rtcp-mux
Expand Down
3 changes: 3 additions & 0 deletions test/parse.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,6 +355,9 @@ test('jsepSdp', function *(t) {
var media = session.media;
t.ok(media && media.length === 2, 'got media');

t.equal(media[0].iceOptions, 'trickle ice2', 'multiple ice options');
t.equal(media[1].iceOptions, 'trickle', 'single ice option');

var video = media[1];
t.equal(video.ssrcGroups.length, 1, '1 ssrc grouping');
t.deepEqual(video.ssrcGroups[0],
Expand Down
Loading