fix ice-options grammar

[fippo]

which dropped everything but a single ice-option (which is the default in webrtc these days).

Do not change the API surface for backward compat.

[fippo]

(looking at https://www.npmjs.com/package/sdp-transform?activeTab=versions this should probably be backported to 2.x)

[ibc]

It would be great to also have a write test to see how it behaves

[fippo]

that is what the parser test does. Currently it misreads

a=ice-options:trickle ice2

as

iceOptions: 'trickle'

which the serialization then simply turns into

a=ice-options:trickle

(sadly this does not explain a huge of munging trickle in Chrome stats...)

[ibc]

(looking at https://www.npmjs.com/package/sdp-transform?activeTab=versions this should probably be backported to 2.x)

Why? This should go to the next version and not to a previous one. 3.x introduced a breaking change but it doesn't mean that we need to keep 2.x with new stuff forever.

[ibc]

I can merge it if ready

[fippo]

well, looking at the numbers there are a lot of people still too laz^W^W stuck on 2.x.

And they will break if Chrome adds a second ice-option and that SDP munging is rejected.

[ibc]

well, looking at the numbers there are a lot of people still too laz^W^W stuck on 2.x.

And they will break if Chrome adds a second ice-option and that SDP munging is rejected.

I understand. Unfortunately @clux is no longer maintaining this repository/project so I don't know what to do here.