Skip to content

fix(json): keep comma after an empty slog group #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RaphaelFakhri wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −0
Open

fix(json): keep comma after an empty slog group #232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions json.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,11 +82,13 @@ func (l *Logger) jsonFormatterItem(jw *jsonWriter, key, value any) {
func (l *Logger) writeSlogValue(jw *jsonWriter, v slogValue) {
switch v.Kind() {
case slogKindGroup:
d := jw.d
jw.start()
for _, attr := range v.Group() {
l.jsonFormatterItem(jw, attr.Key, attr.Value)
}
jw.end()
jw.d = d
default:
a := v.Any()
_, jm := a.(json.Marshaler)
Expand Down
8 changes: 8 additions & 0 deletions logger_121_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,6 +256,14 @@ func TestSlogAttr(t *testing.T) {
)},
},
},
{
name: "log valuer empty group",
expected: `{"level":"info","msg":"message","lv":{},"k":"v"}` + "\n",
kvs: []any{
"lv", testLogValue{slog.GroupValue()},
"k", "v",
},
},
}

for _, c := range cases {
Expand Down