Repository navigation
fix(json): keep comma after an empty slog group - #232
Open
RaphaelFakhri wants to merge 1 commit into
Open
RaphaelFakhri wants to merge 1 commit into
RaphaelFakhri wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CONTRIBUTING.md.Bug fix, not a new feature.
Problem
With
JSONFormatter, a value that resolves to an emptysloggroup produces invalid JSON:Before:
After:
writeSlogValuecallsjw.start()for the nested group, which resets the item counter to 0. An empty group leaves the counter at 0, so the next key is written without a comma.Change
writeSlogValuesaves the counter before writing a group and restores it after. Output for non-empty groups is unchanged.Tests
TestSlogAttrhas a newlog valuer empty groupcase. The case checks both thelogand theslogpaths. It fails without the change and passes with it.go test ./...andgolangci-lint runpass.Fixes #231