Repository navigation
Conversation
Test branch for #625. Uses the split lint-python.yaml from canonical/starflow#199 instead of starflow/main, without the starbase changes that add the docs-linkcheck target. Co-Authored-By: Copilot <198982749+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The compatibility test does not produce its documented failure and must be corrected.
1 open finding
What changed in this PR
Tests Starflow’s split lint workflow against Starbase’s main for compatibility.
Changes:
- Updates
.github/workflows/qa.yamlto use Starflow’s split lint workflow. - Exercises the downstream
docs-linkcheckbehavior.
| File | Summary |
|---|---|
.github/workflows/qa.yaml |
Switches the lint workflow reference, but the expected missing-target failure does not occur and the compatibility test needs adjustment. |
🧠 Review effort: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| - '!({docs/**,*.md,**/*.md,.readthedocs.yaml})' | ||
| lint: | ||
| uses: canonical/starflow/.github/workflows/lint-python.yaml@main | ||
| uses: canonical/starflow/.github/workflows/lint-python.yaml@work/separate-linkcheck |
lengau
added this pull request to stack #631
October 15, 2026 00:06
This was referenced Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Backwards compatibility test for #625. Not intended to merge.
This branch is off
mainwith one extra commit that points thelintjob atcanonical/starflow/.github/workflows/lint-python.yaml@work/separate-linkcheckinstead of
@main.That gives only the starflow half of the change:
code,docs, andlinkcheckas separate jobs(ci(lint-python): split linting into code, docs, and linkcheck jobs starflow#199)
docs-linkchecktarget yet, so thelinkcheckjob isexpected to fail with "No rule to make target 'docs-linkcheck'"
What it tests
Whether starflow's split workflow breaks downstream repos that have not merged
#625 yet, which determines whether starbase has to land
first.
Stacked on this
Docs-only filter test: #630
Related