Replace LOGIN_TO_ACCOUNT_ID_MAP derived value with a personal details selector

src/ONYXKEYS.ts

@@ -1441,7 +1441,6 @@ const ONYXKEYS = {
         PERSONAL_AND_WORKSPACE_CARD_LIST: 'personalAndWorkspaceCardList',
         CARD_FEED_ERRORS: 'cardFeedErrors',
         RAM_ONLY_SORTED_REPORT_ACTIONS: 'sortedReportActions',
-        LOGIN_TO_ACCOUNT_ID_MAP: 'loginToAccountIDMap',
         GUIDE_ACCOUNT_IDS: 'guideAccountIDs',
         SPEND_DATA_SIGNATURE: 'spendDataSignature',
         ONE_ON_ONE_CHAT_REPORT_IDS: 'oneOnOneChatReportIDs',
@@ -2024,7 +2023,6 @@ type OnyxDerivedValuesMapping = {
     [ONYXKEYS.DERIVED.PERSONAL_AND_WORKSPACE_CARD_LIST]: OnyxTypes.PersonalAndWorkspaceCardListDerivedValue;
     [ONYXKEYS.DERIVED.CARD_FEED_ERRORS]: OnyxTypes.CardFeedErrorsDerivedValue;
     [ONYXKEYS.DERIVED.RAM_ONLY_SORTED_REPORT_ACTIONS]: OnyxTypes.SortedReportActionsDerivedValue;
-    [ONYXKEYS.DERIVED.LOGIN_TO_ACCOUNT_ID_MAP]: OnyxTypes.LoginToAccountIDMapDerivedValue;
     [ONYXKEYS.DERIVED.SPEND_DATA_SIGNATURE]: OnyxTypes.SpendDataSignatureDerivedValue;
     [ONYXKEYS.DERIVED.GUIDE_ACCOUNT_IDS]: OnyxTypes.GuideAccountIDsDerivedValue;
     [ONYXKEYS.DERIVED.ONE_ON_ONE_CHAT_REPORT_IDS]: OnyxTypes.OneOnOneChatReportIDsDerivedValue;

src/components/MoneyRequestConfirmationList/sections/AttendeeField.tsx

@@ -5,7 +5,7 @@ import UserPills from '@components/UserPills';
 
 import useAttendees from '@hooks/useAttendees';
 import useLocalize from '@hooks/useLocalize';
-import useOnyx from '@hooks/useOnyx';
+import useLoginToAccountIDMap from '@hooks/useLoginToAccountIDMap';
 
 import {enrichAndSortAttendees} from '@libs/AttendeeUtils';
 import createDynamicRoute from '@libs/Navigation/helpers/dynamicRoutesUtils/createDynamicRoute';
@@ -17,7 +17,6 @@ import {callFunctionIfActionIsAllowed} from '@userActions/Session';
 import CONST from '@src/CONST';
 import type {IOUAction, IOUType} from '@src/CONST';
 import type {TranslationPaths} from '@src/languages/types';
-import ONYXKEYS from '@src/ONYXKEYS';
 import {DYNAMIC_ROUTES} from '@src/ROUTES';
 import type * as OnyxTypes from '@src/types/onyx';
 
@@ -44,7 +43,7 @@ function AttendeeField({formattedAmountPerAttendee, isReadOnly, transactionID, a
     const {shouldUseDropdownRows} = useExpenseFormLayout();
     const {translate, localeCompare} = useLocalize();
     const personalDetailsList = usePersonalDetails();
-    const [loginToAccountIDMap] = useOnyx(ONYXKEYS.DERIVED.LOGIN_TO_ACCOUNT_ID_MAP);
+    const loginToAccountIDMap = useLoginToAccountIDMap();
     const shouldDisplayAttendeesError = formError === 'violations.missingAttendees';
 
     const attendeeSlice = useTransactionSelector(transactionID, attendeeSliceSelector);

src/components/ReportActionItem/MoneyRequestView.tsx

@@ -30,6 +30,7 @@ import useEnvironment from '@hooks/useEnvironment';
 import useHasMultipleSplitChildren from '@hooks/useHasMultipleSplitChildren';
 import {useMemoizedLazyExpensifyIcons} from '@hooks/useLazyAsset';
 import useLocalize from '@hooks/useLocalize';
+import useLoginToAccountIDMap from '@hooks/useLoginToAccountIDMap';
 import useNetwork from '@hooks/useNetwork';
 import useOnyx from '@hooks/useOnyx';
 import usePermissions from '@hooks/usePermissions';
@@ -224,7 +225,7 @@ function MoneyRequestView({
     const {convertToDisplayString, getCurrencySymbol, getCurrencyDecimals} = useCurrencyListActions();
     const {getReportRHPActiveRoute} = useActiveRoute();
     const {showConfirmModal} = useConfirmModal();
-    const [loginToAccountIDMap] = useOnyx(ONYXKEYS.DERIVED.LOGIN_TO_ACCOUNT_ID_MAP);
+    const loginToAccountIDMap = useLoginToAccountIDMap();
 
     const {currentSearchResults} = useSearchResultsContext();
 

src/components/Search/SearchList/ListItem/AttendeesCell.tsx

@@ -5,7 +5,7 @@ import UserDetailsTooltip from '@components/UserDetailsTooltip';
 
 import useDefaultAvatars from '@hooks/useDefaultAvatars';
 import useLocalize from '@hooks/useLocalize';
-import useOnyx from '@hooks/useOnyx';
+import {useAllPersonalDetailsWithoutSnapshots} from '@hooks/usePersonalDetails';
 import useStyleUtils from '@hooks/useStyleUtils';
 import useTheme from '@hooks/useTheme';
 import useThemeStyles from '@hooks/useThemeStyles';
@@ -17,10 +17,10 @@ import colors from '@styles/theme/colors';
 import variables from '@styles/variables';
 
 import CONST from '@src/CONST';
-import ONYXKEYS from '@src/ONYXKEYS';
 import type {Attendee} from '@src/types/onyx/IOU';
 import type {Icon as IconType} from '@src/types/onyx/OnyxCommon';
 
+import {accountIDsByLoginsSelector} from '@selectors/PersonalDetails';
 import React from 'react';
 import {View} from 'react-native';
 
@@ -32,9 +32,9 @@ type AttendeesCellProps = {
 
 function AttendeesCell({attendees, isHovered, isPressed}: AttendeesCellProps) {
     const defaultAvatars = useDefaultAvatars();
-    const [loginToAccountIDMap] = useOnyx(ONYXKEYS.DERIVED.LOGIN_TO_ACCOUNT_ID_MAP);
-    const attendeeIcons: IconType[] = attendees.map((attendee) => {
-        const accountID = loginToAccountIDMap?.[attendee.email ?? ''] ?? CONST.DEFAULT_NUMBER_ID;
+    const [attendeeAccountIDs] = useAllPersonalDetailsWithoutSnapshots(accountIDsByLoginsSelector(attendees.map((attendee) => attendee.email)));
+    const attendeeIcons: IconType[] = attendees.map((attendee, index) => {
+        const accountID = attendeeAccountIDs?.at(index) ?? CONST.DEFAULT_NUMBER_ID;
         return {
             id: accountID,
             name: attendee.displayName ?? attendee.email,

src/components/Table/TableBody.tsx

@@ -164,6 +164,7 @@ function TableBodyList({contentContainerStyle, emptyMessage, onLayout, style, ..
         noResultsStateElement,
         tableListMetadata,
         isEmptyResult,
+        isDefaultViewEmpty,
         scrollWidth,
         tableWidth,
     } = useTableContext<TableData>();
@@ -337,8 +338,10 @@ function TableBodyList({contentContainerStyle, emptyMessage, onLayout, style, ..
         </View>
     );
 
-    const emptyStateContent =
-        tableListMetadata.hasPageHeader && isEmptyResult ? (noResultsStateElement ?? EmptyResultComponent) : (emptyStateElement ?? renderListComponent(ListEmptyComponent));
+    // When the default view hides every row (e.g. all workspaces are archived), no search or filter is active,
+    // so show the empty state rather than "No results".
+    const shouldShowNoResultsState = tableListMetadata.hasPageHeader && isEmptyResult && !isDefaultViewEmpty;
+    const emptyStateContent = shouldShowNoResultsState ? (noResultsStateElement ?? EmptyResultComponent) : (emptyStateElement ?? renderListComponent(ListEmptyComponent));
     const footerElement = renderListComponent(ListFooterComponent);
     // Consumer footer flex growth is useful below normal rows, but inside the combined empty-state
     // footer it can expand over the page header. Preserve the remaining style while disabling growth.

src/components/Table/TableEmptyStates/TableNoResultsState.tsx

@@ -21,10 +21,11 @@ type TableNoResultsStateProps = Omit<GenericEmptyStateComponentProps, 'headerMed
 export default function TableNoResultsState(emptyStateProps: TableNoResultsStateProps) {
     const styles = useThemeStyles();
     const {translate} = useLocalize();
-    const {isEmptyResult, tableListMetadata} = useTableContext();
+    const {isEmptyResult, isDefaultViewEmpty, tableListMetadata} = useTableContext();
     const illustrations = useMemoizedLazyIllustrations(['EmptyShelves']);
 
-    if (!isEmptyResult) {
+    // The default view hiding every row is not a search/filter result, so the empty state handles it instead.
+    if (!isEmptyResult || isDefaultViewEmpty) {
         return null;
     }
 

src/hooks/useLoginToAccountIDMap.ts

@@ -0,0 +1,10 @@
+import {loginToAccountIDMapSelector} from '@selectors/PersonalDetails';
+
+import {useAllPersonalDetailsWithoutSnapshots} from './usePersonalDetails';
+
+function useLoginToAccountIDMap() {
+    const [loginToAccountIDMap] = useAllPersonalDetailsWithoutSnapshots(loginToAccountIDMapSelector);
+    return loginToAccountIDMap;
+}
+
+export default useLoginToAccountIDMap;

src/libs/AttendeeUtils.ts

@@ -1,7 +1,7 @@
 import type {LocaleContextProps} from '@components/LocaleContextProvider';
 
 import CONST from '@src/CONST';
-import type {LoginToAccountIDMapDerivedValue, PersonalDetailsList, PolicyCategories} from '@src/types/onyx';
+import type {PersonalDetailsList, PolicyCategories} from '@src/types/onyx';
 import type {Attendee} from '@src/types/onyx/IOU';
 import type {CurrentUserPersonalDetails} from '@src/types/onyx/PersonalDetails';
 
@@ -134,7 +134,7 @@ type AttendeeWithAccountID = Attendee & {accountID?: number};
  */
 function enrichAndSortAttendees(
     attendees: Attendee[] | undefined,
-    loginToAccountIDMap: OnyxEntry<LoginToAccountIDMapDerivedValue>,
+    loginToAccountIDMap: OnyxEntry<Record<string, number>>,
     personalDetailsList: OnyxEntry<PersonalDetailsList>,
     localeCompare: LocaleContextProps['localeCompare'],
 ): AttendeeWithAccountID[] | undefined {

src/libs/actions/OnyxDerived/ONYX_DERIVED_VALUES.ts

@@ -6,7 +6,6 @@ import type {OnyxDerivedValueConfig} from './types';
 
 import cardFeedErrorsConfig from './configs/cardFeedErrors';
 import guideAccountIDsConfig from './configs/guideAccountIDs';
-import loginToAccountIDMapConfig from './configs/loginToAccountIDMap';
 import nonPersonalAndWorkspaceCardListConfig from './configs/nonPersonalAndWorkspaceCardList';
 import oneOnOneChatReportIDsConfig from './configs/oneOnOneChatReportIDs';
 import outstandingReportsByPolicyIDConfig from './configs/outstandingReportsByPolicyID';
@@ -30,7 +29,6 @@ const ONYX_DERIVED_VALUES = {
     [ONYXKEYS.DERIVED.PERSONAL_AND_WORKSPACE_CARD_LIST]: personalAndWorkspaceCardListConfig,
     [ONYXKEYS.DERIVED.CARD_FEED_ERRORS]: cardFeedErrorsConfig,
     [ONYXKEYS.DERIVED.RAM_ONLY_SORTED_REPORT_ACTIONS]: sortedReportActionsConfig,
-    [ONYXKEYS.DERIVED.LOGIN_TO_ACCOUNT_ID_MAP]: loginToAccountIDMapConfig,
     [ONYXKEYS.DERIVED.GUIDE_ACCOUNT_IDS]: guideAccountIDsConfig,
     [ONYXKEYS.DERIVED.SPEND_DATA_SIGNATURE]: spendDataSignatureConfig,
     [ONYXKEYS.DERIVED.ONE_ON_ONE_CHAT_REPORT_IDS]: oneOnOneChatReportIDsConfig,

src/selectors/PersonalDetails.ts

@@ -95,6 +95,43 @@ const optimisticPersonalDetailsSelector = (personalDetailsList: OnyxEntry<Person
     return optimisticPersonalDetails;
 };
 
+const loginToAccountIDMapCache = new WeakMap<PersonalDetailsList, Record<string, number>>();
+
+/**
+ * Maps each lowercased login to its accountID. When two accounts share a login, a closed or optimistic one loses to the other.
+ * Cached on the list reference, so every Search row that reads it after the same write shares one build.
+ */
+const loginToAccountIDMapSelector = (personalDetailsList: OnyxEntry<PersonalDetailsList>): Record<string, number> => {
+    if (!personalDetailsList) {
+        return {};
+    }
+
+    const cachedLoginToAccountIDMap = loginToAccountIDMapCache.get(personalDetailsList);
+    if (cachedLoginToAccountIDMap) {
+        return cachedLoginToAccountIDMap;
+    }
+
+    const loginToAccountIDMap: Record<string, number> = {};
+    for (const personalDetails of Object.values(personalDetailsList)) {
+        if (!personalDetails?.login) {
+            continue;
+        }
+        const login = personalDetails.login.toLowerCase();
+        const existingAccountID = loginToAccountIDMap[login];
+        const existingDetail = existingAccountID === undefined ? undefined : personalDetailsList[existingAccountID];
+        if (!existingDetail || existingDetail.isClosed || existingDetail.isOptimisticPersonalDetail) {
+            loginToAccountIDMap[login] = personalDetails.accountID;
+        }
+    }
+    loginToAccountIDMapCache.set(personalDetailsList, loginToAccountIDMap);
+    return loginToAccountIDMap;
+};
+
+const accountIDsByLoginsSelector = (logins: Array<string | undefined>) => (personalDetailsList: OnyxEntry<PersonalDetailsList>) => {
+    const loginToAccountIDMap = loginToAccountIDMapSelector(personalDetailsList);
+    return logins.map((login) => loginToAccountIDMap[login ?? ''] ?? CONST.DEFAULT_NUMBER_ID);
+};
+
 const newAccountIDsAndLoginsSelector = (invitedEmailsToAccountIDs: InvitedEmailsToAccountIDs | undefined) => (personalDetailsList: OnyxEntry<PersonalDetailsList>) =>
     getNewAccountIDsAndLogins(invitedEmailsToAccountIDs, personalDetailsList);
 
@@ -125,6 +162,8 @@ export {
     accountIDToLoginSelector,
     isPersonalDetailOptimistic,
     optimisticPersonalDetailsSelector,
+    loginToAccountIDMapSelector,
+    accountIDsByLoginsSelector,
     createDisplayDetailsByAccountIDsSelector,
     newAccountIDsAndLoginsSelector,
     displayNameSelector,

src/types/onyx/DerivedValues.ts

@@ -211,14 +211,6 @@ type SortedReportActionsDerivedValue = {
  */
 type PersonalAndWorkspaceCardListDerivedValue = CardList;
 
-/**
- * The derived value mapping each user's login (lowercased) to their accountID.
- *
- * Replaces the imperative `emailToPersonalDetailsCache` login lookup that was built via `Onyx.connect`
- * in `PersonalDetailsUtils` (see issue #66391). Keys are lowercased since logins/emails are case-insensitive.
- */
-type LoginToAccountIDMapDerivedValue = Record<string, number>;
-
 /**
  * The accountIDs of every Expensify Guide known to the personal details list, sorted ascending.
  * Lets callers check for a guide participant without re-scanning the whole list (see issue #66413).
@@ -255,7 +247,6 @@ export type {
     NonPersonalAndWorkspaceCardListDerivedValue,
     PersonalAndWorkspaceCardListDerivedValue,
     CardFeedErrorsDerivedValue,
-    LoginToAccountIDMapDerivedValue,
     GuideAccountIDsDerivedValue,
     SpendDataSignatureDerivedValue,
     OneOnOneChatReportIDsDerivedValue,

src/types/onyx/index.ts

@@ -62,7 +62,6 @@ import type {
     CardFeedErrorsDerivedValue,
     GuideAccountIDsDerivedValue,
     SpendDataSignatureDerivedValue,
-    LoginToAccountIDMapDerivedValue,
     NonPersonalAndWorkspaceCardListDerivedValue,
     OneOnOneChatReportIDsDerivedValue,
     OutstandingReportsByPolicyIDDerivedValue,
@@ -501,7 +500,6 @@ export type {
     NonPersonalAndWorkspaceCardListDerivedValue,
     PersonalAndWorkspaceCardListDerivedValue,
     CardFeedErrorsDerivedValue,
-    LoginToAccountIDMapDerivedValue,
     GuideAccountIDsDerivedValue,
     SpendDataSignatureDerivedValue,
     OneOnOneChatReportIDsDerivedValue,