Replace LOGIN_TO_ACCOUNT_ID_MAP derived value with a personal details selector

[sosek108]

Explanation of Change

This targets the Onyx store bump in Expensify#98956.

LOGIN_TO_ACCOUNT_ID_MAP is computed by OnyxDerived from one key, PERSONAL_DETAILS_LIST. The engine rebuilds the whole map on every personal-details write, writes it back into Onyx and to disk, and every write hands consumers a new object even when no login moved. One consumer is AttendeesCell, a Search row, so every row on the Search page re-renders on any personal-details write.

This replaces the derived value with selectors over the live personal details list (not the Search snapshot), like the derived value read. The map keeps the config's rules: logins are lowercased, and when two accounts share a login a closed or optimistic one loses. It is cached per personal details list reference, so all rows mounted at once share one build per write instead of each row building its own. AttendeesCell selects only the accountIDs of its own attendees, so a write that doesn't change them leaves the row alone. AttendeeField and MoneyRequestView read the full map through a new useLoginToAccountIDMap hook. The config, its key and its type are removed. The persisted row is left on disk, as with the TODOS removal.

A new reassure test runs unchanged on the base and on this branch, with 50 Search rows mounted. Ten renames of a user who attends none of the rows go from 11 row renders (256 ms) to 1 (17 ms), and with 5,000 more people in the list from 11 renders (244 ms) to 1 (32 ms). The whole write loop over the large list goes from 958 ms to 68 ms, because the engine no longer rebuilds and stores a 5,000-entry map on each write. When the account behind an attendee's login really changes, every row still re-renders on both, and the time is the same within noise.

Fixed Issues

$ https://github.com/callstack-internal/expensify-issues/issues/3075
PROPOSAL:

Tests

1. Create an expense in a workspace with attendee tracking enabled, and add two attendees who are users you know.
2. On the confirmation page, verify the attendee pills show their avatars and names.
3. Submit the expense, open it and verify the Attendees row shows the same people with their avatars.
4. Go to Search > Expenses, show the Attendees column and verify the row shows the attendees' avatars, and hovering an avatar shows the right person.
5. Rename one of the attendees (or have them change their avatar), then come back to Search and the expense. Verify the new name or avatar shows.

• Verify that no errors appear in the JS console

Offline tests

1. Go offline.
2. Open the expense from the tests and Search > Expenses. Verify the attendees still show with their avatars.
3. Add an attendee to the expense while offline. Verify it shows on the expense and in the Search row.
4. Go back online. Verify the attendees stay the same.

QA Steps

Same as tests.

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If the PR adds or modifies the UI:
  • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
  • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
  • I verified all new/changed elements have meaningful accessible names and roles.
  • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

[coderabbitai]

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

• Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}