To be deleted: Compare search vs Sidbear utils alternateText

.claude/agents/code-inline-reviewer.md

@@ -1,7 +1,7 @@
 ---
 
 name: code-inline-reviewer
-description: Reviews code and creates inline comments for specific rule violations.
+description: Reviews Expensify App code and creates inline comments for specific rule violations.
 tools: Glob, Grep, Read, Bash, BashOutput
 model: inherit
 ---
@@ -14,9 +14,9 @@ Your job is to scan through changed files and create **inline comments** for spe
 
 ## Rules
 
-Coding standards are defined as individual rule files in `.claude/skills/coding-standards/rules/`.
+Coding standards are defined as individual rule files in `.claude/skills/app-coding-standards/rules/`.
 
-**Always use the `coding-standards` skill to review changed files.**
+**Always use the `app-coding-standards` skill to review changed files.**
 
 Each rule file contains:
 
@@ -28,7 +28,7 @@ Each rule file contains:
 ## Instructions
 
 1. **Load all rules:**
-   - Use Glob to list all `.md` files in `.claude/skills/coding-standards/rules/`
+   - Use Glob to list all `.md` files in `.claude/skills/app-coding-standards/rules/`
    - Read ALL rule files
    - Build an explicit checklist of all rules (ruleId + title) from the YAML frontmatter
    - Build a ruleId-to-filename mapping for creating docs links in comments
@@ -62,7 +62,7 @@ Each rule file contains:
 Use this format for the `body` field of each violation:
 
 ```
-### ❌ <Rule ID> [(docs)](https://github.com/Expensify/App/blob/main/.claude/skills/coding-standards/rules/<rule-filename>.md)
+### ❌ <Rule ID> [(docs)](https://github.com/Expensify/App/blob/main/.claude/skills/app-coding-standards/rules/<rule-filename>.md)
 
 <Reasoning>
 

.claude/commands/review-code-pr.md

@@ -1,6 +1,6 @@
 ---
 allowed-tools: Bash(gh pr diff:*),Bash(gh pr view:*),Bash(check-compiler.sh:*)
-description: Run the coding-standards rule linter on a PR diff. Use when user wants to review their changes against our custom rules.
+description: Run the app-coding-standards rule linter on an Expensify App PR diff. Use when user wants to review their App changes against our custom rules.
 ---
 
 Perform a comprehensive PR review using a specialized subagent:

.claude/skills/agent-device/SKILL.md

@@ -10,7 +10,7 @@ allowed-tools: Bash(agent-device *) Bash(npm root *) Bash(scripts/is-hybrid-app.
 
 These checks evaluate at skill load. If any line shows `FAIL`, stop and surface the fix before running any device command.
 
-`agent-device` version: !`R=0.18.0; V=$(agent-device --version 2>/dev/null); [ -n "$V" ] && [ "$(printf '%s\n%s\n' "$R" "$V" | sort -V | head -1)" = "$R" ] && echo "OK ($V)" || echo "FAIL (need v$R+, got: ${V:-not installed}). Fix: npm install -g agent-device@latest"`
+`agent-device` version: !`R=0.20.0; V=$(agent-device --version 2>/dev/null); [ -n "$V" ] && [ "$(printf '%s\n%s\n' "$R" "$V" | sort -V | head -1)" = "$R" ] && echo "OK ($V)" || echo "FAIL (need v$R+, got: ${V:-not installed}). Fix: npm install -g agent-device@latest"`
 
 Bundled CLI skills dir: !`D="$(npm root -g)/agent-device/skills/agent-device"; test -s "$D/SKILL.md" && echo "OK ($D)" || echo "FAIL (missing $D/SKILL.md). Fix: npm install -g agent-device@latest"`
 
@@ -121,4 +121,6 @@ Read these files directly for device automation guidance (bootstrap, exploration
 
 ## Flows
 
-Repeatable steps (sign-in, onboarding, etc.) are captured as composable `.ad` snippets under [`flows/`](flows/README.md). For interactive usage, propose and run only `flows/macros/` helpers. `flows/tests/` belongs to a separate QA workflow and must not be proposed by this skill; QA/perf runs execute them via `agent-device test <path>`.
+This skill owns interactive automation only: reusable setup and navigation macros under [`flows/macros/`](flows/README.md), with platform overrides under `flows/macros/<platform>/`. Propose and run macros through the [Agent decision loop](flows/README.md). `flows/README.md` is also the reference for the `.ad` metadata spec, selector rules, and recording workflow, so read it before authoring any `.ad` file in this repository.
+
+Measurement flows live in the [`measure-telemetry-span`](../measure-telemetry-span/SKILL.md) skill, which owns its own `flows/` and runner. Do not add measurement flows here.

.claude/skills/agent-device/flows/README.md

@@ -1,12 +1,13 @@
 # Flows
 
+This file is the reference for every `.ad` file in the repository: the metadata spec, selector rules, recording, and maintenance.
+
 ## Directory layout
 
-- `macros/` - reusable helpers for common setup/navigation actions that stop in a navigable state for further interactive work.
-- `macros/<platform>/` - platform-specific overrides of a `macros/` flow, for flows whose selectors differ per platform. See [Platform scoping](#platform-scoping).
-- `tests/` - critical-scenario scripts for QA/perf verification that assert explicit outcomes (for example Sentry spans) and then stop.
+1. `macros/` contains reusable setup and navigation helpers for interactive work. These are the only flows an interactive agent may propose.
+2. `macros/<platform>/` contains platform-specific overrides of a `macros/` flow, for flows whose selectors differ per platform. See [Platform scoping](#platform-scoping).
 
-Composable `.ad` snippets - bounded units of work. A flow may span one or multiple screens as long as it represents a coherent, reusable action with clear start (`@pre`) and completion (`@post`) checkpoints. Each flow advertises machine-matchable metadata (`@pre`, `@post`, `@tag`, `@param`) via `# @`-prefixed comment headers, while flow type is derived from location (`flows/macros/` or `flows/tests/`).
+`macros/` contains composable `.ad` snippets. The caller owns application startup, authentication, platform selection, session state, and cleanup. A flow may span one or multiple screens as long as it represents a coherent action with clear start (`@pre`) and completion (`@post`) checkpoints.
 
 ## Platform scoping
 
@@ -34,29 +35,24 @@ Before manually navigating, use this human-in-the-loop loop:
 7. `agent-device replay <path> -e KEY=VALUE ...`.
 8. If the flow declares `@post`, verify each `@post` with `is exists`. On success, re-enter the loop only if the user's stated goal is not complete; otherwise stop and report completion. On failure, propose peer flow/manual fallback options and ask before continuing. If no `@post` is declared (utility flow), rely on explicit user confirmation or the next snapshot before continuing.
 
-## QA workflow (separate)
+## Replay lifecycle
 
-`flows/tests/` is reserved for dedicated QA automation and should not be offered to users as part of the interactive helper loop above. Run these flows with the dedicated test runner:
-
-```bash
-agent-device test .claude/skills/agent-device/flows/tests/<name>.ad -e KEY=VALUE ...
-```
+No flow in this repository owns application lifecycle, so none of them is a self-contained `agent-device test` input. `agent-device test` creates an isolated session per attempt; use it only for scripts that own `context`, `open`, and cleanup. Repository flows expect the caller to open the app and prepare a named session first.
 
 ## Metadata header spec
 
 Each flow starts with `# @key value` comment lines. The `.ad` parser treats `#` lines as no-ops, so headers cost nothing at replay time.
 
-| Field    | Cardinality | Value                                                                                            |
-| -------- | ----------- | ------------------------------------------------------------------------------------------------ |
-| `@desc`  | 1           | One-line human summary.                                                                          |
-| `@pre`   | 1..N        | Selector that must resolve in the current snapshot. Multiple lines are ANDed.                    |
-| `@post`  | 0..N        | Selector expected after replay. Multiple lines are ANDed. Used for chaining + success.           |
-| `@tag`   | 0..N        | Free-form category (`auth`, `onboarding`, ...) or scoped (`sentry-<spanName>`).                  |
-| `@param` | 0..N        | Runtime input contract: `@param KEY description.` Use with `${KEY}` in flow body.                |
+| Field    | Cardinality | Value                                                                                  |
+| -------- | ----------- | -------------------------------------------------------------------------------------- |
+| `@desc`  | 1           | One-line human summary.                                                                |
+| `@pre`   | 1..N        | Selector that must resolve in the current snapshot. Multiple lines are ANDed.           |
+| `@post`  | 0..N        | Selector expected after replay. Multiple lines are ANDed. The flow body enforces them. |
+| `@param` | 0..N        | Runtime input contract: `@param KEY description.` Use with `${KEY}` in flow body.      |
 
 Selector syntax matches the body: `id="..."`, `role="..." label="..."`, `text="..."`, `||` for fallbacks.
 
-## Parametrization (`agent-device` v0.13.0+)
+## Parametrization
 
 Declare runtime inputs via metadata (`@param`) and reference them in the body with `${VAR}` interpolation. Values are supplied by caller arguments (`-e`) or shell imports (`AD_VAR_*`) - never by in-file `env` directives.
 
@@ -78,11 +74,16 @@ agent-device replay <flow>.ad -e EMAIL=other@example.com
 ## Authoring rules
 
 - **No `open`, no `close`, no `context` header.** Caller owns lifecycle.
-- **No fixed `wait` calls.** `fill`/`press` resolve selectors with retry. Only add `wait <selector>` for real post-action blocks.
+- **No fixed-duration `wait` calls.** Guard every asynchronous transition with `wait "<selector>" <timeoutMs>`, which polls until the selector resolves. A bare `wait <ms>` only burns wall clock.
+- **No command flags in a flow body.** The `.ad` parser only reads flags for `press`, `fill`, `click`, and a few capture commands; for `is`, `wait`, and `find` it treats `--first` and friends as positionals. Disambiguate with a tighter selector instead.
 - **Durable selectors.** Prefer `id=...` first, then `role=... label=...`, with `||` fallbacks. Avoid `@eN` refs.
+- **A `@pre` must distinguish the start screen from the destination.** A bottom-tab label such as `text="Home"` is rendered on every tab, so asserting it proves nothing. Anchor on a screen-scoped `id=` instead - `id="HomePage"` for Home, `id="BaseSidebarScreen"` for Inbox - otherwise a flow that starts on the wrong screen reports success while the action it measures never happens.
 - **Confirm every selector on the platform it is written for.** `snapshot -i` prints display tags, which are not selector values - a node printed as `[text-field]` may only match `role="textbox"`. Check the exit code of `agent-device is visible "<selector>"` before committing a selector, and never carry one across platforms unchecked.
-- **Every flow declares `@desc` and `@pre`.** Add `@post` for outcome-bearing flows; utility flows (for example `go-back`) may omit it. Add `@tag` when applicable.
-- **Choose directory intentionally.** Put reusable setup/navigation steps in `flows/macros/`; put outcome verification scenarios in `flows/tests/`.
+- **Every flow declares `@desc` and `@pre`.** Outcome-bearing flows also declare at least one `@post`. Utility macros (for example `go-back`) may omit `@post`.
+- **Every declared `@pre` and `@post` runs as a body assertion.** Use `is exists` or `wait`. Metadata documents the contract but does not execute it.
+- **Assertion order decides whether a pass means anything.** Enforce every `@pre` before the first mutation and every `@post` after the last one. An assertion on the wrong side of a mutation lets a flow report success from the screen it started on.
+- **No `find <selector> "click"`.** It resolves at runtime and hides which element was hit. Press an exact selector instead.
+- **A bare `label=` alternative must carry `hittable=true`.** Without it the match can land on an off-screen or non-interactive node and the press silently does nothing.
 - **Keep scope coherent, not artificially tiny.** Flows can span multiple screens when that sequence is the reusable intent (for example "create and submit manual expense").
 - **Peers share `@pre` and differ on `@post`.** One flow per narrow outcome is better than a mega-flow with conditional branches.
 - **Use `@param` for substituted values.** If a literal is interpolated into the body, declare `# @param KEY description.` and reference it as `${KEY}`.
@@ -94,21 +95,24 @@ agent-device replay <flow>.ad -e EMAIL=other@example.com
 1. Drive the target screen manually.
 2. Start a session with `--save-script`:
    ```bash
-   agent-device open <app> --save-script .claude/skills/agent-device/flows/<kind>/<name>.ad
+   agent-device open <app> --save-script .claude/skills/agent-device/flows/macros/<name>.ad
    ```
 3. Perform the steps.
 4. `agent-device close` - flushes the `.ad`.
 5. Edit the generated file:
    - Delete the `context` line, leading `open ... --relaunch`, trailing `close`, and eyeballing `wait`s.
-   - Move file to `flows/macros/` or `flows/tests/`, then add `@desc`, `@pre`, optional `@post`, optional `@tag`, and any needed `@param` headers.
-6. Verify: pre-check from a matching state, replay, post-check.
+   - Move the file to `flows/macros/`, then add `@desc`, `@pre`, optional `@post`, and any needed `@param` headers.
+6. Add executable checks for every declared `@pre` and `@post`.
+7. Verify: pre-check from a matching state, replay, post-check.
 
 ## Maintenance
 
-Heal selector drift in place:
+Heal selector drift by hand. Replay the flow and read the divergence report:
 
 ```bash
-agent-device replay -u .claude/skills/agent-device/flows/<kind>/<name>.ad
+agent-device replay <path-to-flow>.ad --session <name>
 ```
 
-Re-verify `@pre`/`@post` still hold, then commit. Note: `replay -u` can rewrite interpolated lines to concrete selectors/values; review diffs and restore `${KEY}` placeholders where needed. Keep runtime inputs in `@param` + `-e`/`AD_VAR_*`; do not reintroduce in-file `env` directives.
+Every divergence carries ranked selector suggestions. Apply them yourself: `replay --update`/`-u` no longer rewrites the `.ad` file. Editing by hand also keeps `${KEY}` placeholders intact. Re-verify `@pre`/`@post` still hold, then commit. Keep runtime inputs in `@param` + `-e`/`AD_VAR_*`; do not reintroduce in-file `env` directives.
+
+After editing a flow, re-read the authoring rules above and replay it from a matching start state. A green replay plus enforced `@pre`/`@post` is the check.

.claude/skills/agent-device/flows/macros/android/complete-onboarding.ad

@@ -1,14 +1,14 @@
 context platform=android
 # @desc   Complete onboarding with minimal choices (skip work email, pick "Something else" purpose, enter generic name). Lands on Home.
 # @pre    text="What’s your work email?"
-# @post   text="Home"
 # @post   role="button" label="Search"
-# @tag    onboarding
 # @param  FIRST_NAME First name to enter on onboarding profile step.
 # @param  LAST_NAME Last name to enter on onboarding profile step.
 
 press "id=\"onboardingPrivateEmailSkipButton\" || role=\"button\" label=\"Skip\" || label=\"Skip\""
+wait "label=\"Something else\""
 press "role=\"button\" label=\"Something else\" || label=\"Something else\""
+wait "label=\"First name\" editable=true"
 fill "role=\"textfield\" label=\"First name\" editable=true || label=\"First name\" editable=true" "${FIRST_NAME}"
 fill "role=\"textfield\" label=\"Last name\" editable=true || label=\"Last name\" editable=true" "${LAST_NAME}"
 press "role=\"button\" label=\"Continue\" || label=\"Continue\""

.claude/skills/agent-device/flows/macros/android/send-message.ad

@@ -1,8 +1,7 @@
 context platform=android
-# @desc   Send a chat message from inside an already-open chat. Reusable helper for setting up state in other flows. Does not navigate or open a chat - assumes the composer is visible. For the QA scenario that exercises the ManualSendMessageVisible Sentry span, see flows/tests/send-message.ad.
+# @desc   Send a chat message from inside an already-open chat. Reusable helper for setting up state in other flows. Does not navigate or open a chat - assumes the composer is visible.
 # @pre    label="Write something..." editable=true
 # @post   label="Write something..." editable=true
-# @tag    chat
 # @param  MESSAGE Message text to send in the currently open chat.
 
 is exists "label=\"Write something...\" editable=true"

.claude/skills/agent-device/flows/macros/android/sign-in.ad

@@ -3,8 +3,8 @@ context platform=android
 # @pre    id="username"
 # @pre    role="button" label="Continue"
 # @post   role="button" label="Join" || role="button" label="Search"
-# @tag    auth
 # @param  EMAIL Login email. Use randomized alias format `agent-device-testing+<9digits>@gmail.com` to avoid account flagging.
 
-fill "id=\"username\" || label=\"Phone or email\" editable=true" "${EMAIL}"
+press "id=\"username\" || role=\"edittext\" label=\"Phone or email\" editable=true || label=\"Phone or email\" editable=true"
+fill "id=\"username\" || role=\"edittext\" label=\"Phone or email\" editable=true || label=\"Phone or email\" editable=true" "${EMAIL}"
 press "role=\"button\" label=\"Continue\" || label=\"Continue\""

.claude/skills/agent-device/flows/macros/complete-onboarding.ad

@@ -2,7 +2,6 @@
 # @pre    text="What’s your work email?"
 # @post   text="Home"
 # @post   role="button" label="Search"
-# @tag    onboarding
 # @param  FIRST_NAME First name to enter on onboarding profile step.
 # @param  LAST_NAME Last name to enter on onboarding profile step.
 

.claude/skills/agent-device/flows/macros/go-back.ad

@@ -1,4 +1,3 @@
 # @desc   Generic back navigation via the HeaderWithBackButton chevron. Works on any screen that mounts HeaderWithBackButton (Create Expense, Search, Report details, settings pages, etc.).
 # @pre    role="button" label="Back"
-# @tag    navigation
 press "role=\"button\" label=\"Back\""

.claude/skills/agent-device/flows/macros/join.ad

@@ -0,0 +1,6 @@
+# @desc   Press Join on the post-sign-in welcome screen to create the account and enter onboarding.
+# @pre    role="button" label="Join"
+# @post   text="What’s your work email?"
+# @tag    auth
+
+press "role=\"button\" label=\"Join\" || label=\"Join\""

.claude/skills/agent-device/flows/macros/return-to-inbox.ad

@@ -0,0 +1,8 @@
+# @desc   Return from a child screen to the Inbox and wait for its sidebar anchor.
+# @pre    role="button" label="Back"
+# @post   id="BaseSidebarScreen"
+is exists "role=\"button\" label=\"Back\""
+press "role=\"button\" label=\"Back\""
+wait "role=\"tab\" label=\"Inbox\" || role=\"tab\" label=\"Inbox. Your review is required\" || label=\"Inbox\" hittable=true || label=\"Inbox. Your review is required\" hittable=true" 10000
+press "role=\"tab\" label=\"Inbox\" || role=\"tab\" label=\"Inbox. Your review is required\" || label=\"Inbox\" hittable=true || label=\"Inbox. Your review is required\" hittable=true"
+wait "id=\"BaseSidebarScreen\"" 10000

.claude/skills/agent-device/flows/macros/send-message.ad

@@ -1,7 +1,6 @@
-# @desc   Send a chat message from inside an already-open chat. Reusable helper for setting up state in other flows. Does not navigate or open a chat - assumes the composer is visible. For the QA scenario that exercises the ManualSendMessageVisible Sentry span, see flows/tests/send-message.ad.
+# @desc   Send a chat message from inside an already-open chat. Reusable helper for setting up state in other flows. Does not navigate or open a chat - assumes the composer is visible.
 # @pre    label="Write something..." editable=true
 # @post   label="Write something..." editable=true
-# @tag    chat
 # @param  MESSAGE Message text to send in the currently open chat.
 
 is exists "label=\"Write something...\" editable=true"

.claude/skills/agent-device/flows/macros/switch-to-home.ad

@@ -0,0 +1,6 @@
+# @desc   Switch to the Home tab and wait for the Home screen anchor.
+# @pre    role="tab" label="Home" || label="Home" hittable=true
+# @post   id="HomePage"
+is exists "role=\"tab\" label=\"Home\" || label=\"Home\" hittable=true"
+press "role=\"tab\" label=\"Home\" || label=\"Home\" hittable=true"
+wait "id=\"HomePage\"" 10000

.claude/skills/agent-device/flows/macros/web/complete-onboarding.ad

@@ -1,9 +1,8 @@
 context platform=web
 # @desc   Complete onboarding with minimal choices (skip work email, pick "Something else" purpose, enter generic name). Lands on Home.
 # @pre    text="What’s your work email?"
-# @post   text="Home"
+# @post   role="heading" label="Home"
 # @post   role="button" label="Search"
-# @tag    onboarding
 # @param  FIRST_NAME First name to enter on onboarding profile step.
 # @param  LAST_NAME Last name to enter on onboarding profile step.