Skip to content

To be deleted: Compare search vs Sidbear utils alternateText - #62

Closed
sosek108 wants to merge 3354 commits into
fix/lhn-search-alt-text-parityfrom
fix/search-adopt-lhn-alternate-text
Closed

sosek108 wants to merge 3354 commits into
fix/lhn-search-alt-text-parityfrom
fix/search-adopt-lhn-alternate-text

Conversation

@sosek108

@sosek108 sosek108 commented Sep 1, 2026

Copy link
Copy Markdown

Explanation of Change

Fixed Issues

$
PROPOSAL:

Tests

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@coderabbitai

coderabbitai Bot commented Sep 1, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Essentials

Run ID: e9a4705b-fe01-4642-ad03-63e07fce0fd1

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

sosek108 and others added 27 commits September 10, 2026 11:58
A report field value is computed once and frozen when the report is approved,
and a title formula stops recomputing at the same point, while these amounts
only exist after the payment converts. Resolving them on the client therefore
either renders an amount that can never arrive or, once recomputed, one that
cannot be corrected when a payment is later reversed. Without these cases the
tokens fall through to the unknown-token path, which defers to the backend, so
a title using them shows the backend's value rather than raw placeholder text.

The tokens stay documented for export templates, which evaluate on demand and
so are unaffected by the freeze.
…update

[No QA] Update Amex link for new form
…fy-card-view-transactions

[No QA] Docs updates for E/A#90402 View transactions shortcut on Expensify Card
…ng-distance

[Commuter Exclusion] Allow editing historical distance expenses
…ging-toggle-native-fix

Fix staging server toggle resetting on cold start in release builds
…te-flicker

Fix commuter distance flicker after rate changes
…ance-move-selfdm-99713

Fix map/GPS distance expenses skipping home address check on move
…ts-newTransactionHighlight-and-RHPLayout-followups

[CP Staging] revert: refactor the new-transaction highlight rail and the wide RHP width model
@sosek108
sosek108 force-pushed the fix/search-adopt-lhn-alternate-text branch from 68cf36f to dc77b33 Compare September 10, 2026 11:11
…ilDomainControlled

[No QA] Docs updates for E/A#99108 troubleshoot adding a work email during setup
stitesExpensify and others added 29 commits September 11, 2026 16:50
…odeowner

Add Julesssss as code owner for .claude/skills/
…e-skill-names

Give App coding standards a unique skill name
Co-authored-by: TaduJR <TaduJR@users.noreply.github.com>
…imaryLoginFallback

Fall back to the session email when account.primaryLogin is missing in BookTravelButton
…ss-paths-we-cannot-measure

 Make receipt loss attributable to the path that caused it
…e-a11y-workspace-pickers-save

[CP Staging] Revert "Gate workspace picker selection behind a Save button (a11y On Input, PR 11)"
…TestsWorkspaceIndex

[No QA] Look up the Workspace navigator by name in NavigateTests
…ontSize

[Design Polish] Use 15px bold for content card and widget headers
…ciergeIcon

Use one-color Concierge icon in page header top right
…em-infinite-loading

fix: remove per diem page loading gate that never resolves
The claude-review-toolkit pin predates the App coding standards skill
rename and hardcodes the old rules path, so every authorized review run
fails in Extract allowed rules. Bump the pin to the ref that added the
rules_directory input and pass the renamed directory through it.
…r-activity-timeouts

Lower the Pusher activity and pong timeouts from the SDK defaults
Auth and Web-Expensify pin the merge commit that added the
rules_directory input. That tree is identical to the branch commit this
workflow pinned, so adopt the shared SHA to give the three repositories
one pin and one bump point.
…aude-review-rules-path

[No QA] Point Claude review at the renamed coding standards rules
…o/beta-overrides-back-navigation

Open beta overrides over the screen the test tools modal was opened from
@sosek108 sosek108 closed this Sep 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.