Repository navigation
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Essentials Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
A report field value is computed once and frozen when the report is approved, and a title formula stops recomputing at the same point, while these amounts only exist after the payment converts. Resolving them on the client therefore either renders an amount that can never arrive or, once recomputed, one that cannot be corrected when a payment is later reversed. Without these cases the tokens fall through to the unknown-token path, which defers to the backend, so a title using them shows the backend's value rather than raw placeholder text. The tokens stay documented for export templates, which evaluate on demand and so are unaffected by the freeze.
…update [No QA] Update Amex link for new form
…fy-card-view-transactions [No QA] Docs updates for E/A#90402 View transactions shortcut on Expensify Card
…ng-distance [Commuter Exclusion] Allow editing historical distance expenses
…-fork into Guccio163/button/cleanup
…ging-toggle-native-fix Fix staging server toggle resetting on cold start in release builds
…te-flicker Fix commuter distance flicker after rate changes
…ance-move-selfdm-99713 Fix map/GPS distance expenses skipping home address check on move
…ts-newTransactionHighlight-and-RHPLayout-followups [CP Staging] revert: refactor the new-transaction highlight rail and the wide RHP width model
sosek108
force-pushed
the
fix/search-adopt-lhn-alternate-text
branch
from
September 10, 2026 11:11
68cf36f to
dc77b33
Compare
…ilDomainControlled [No QA] Docs updates for E/A#99108 troubleshoot adding a work email during setup
…odeowner Add Julesssss as code owner for .claude/skills/
…e-skill-names Give App coding standards a unique skill name
Co-authored-by: TaduJR <TaduJR@users.noreply.github.com>
…imaryLoginFallback Fall back to the session email when account.primaryLogin is missing in BookTravelButton
…ss-paths-we-cannot-measure Make receipt loss attributable to the path that caused it
…e-a11y-workspace-pickers-save [CP Staging] Revert "Gate workspace picker selection behind a Save button (a11y On Input, PR 11)"
…TestsWorkspaceIndex [No QA] Look up the Workspace navigator by name in NavigateTests
…ontSize [Design Polish] Use 15px bold for content card and widget headers
…ciergeIcon Use one-color Concierge icon in page header top right
…em-infinite-loading fix: remove per diem page loading gate that never resolves
The claude-review-toolkit pin predates the App coding standards skill rename and hardcodes the old rules path, so every authorized review run fails in Extract allowed rules. Bump the pin to the ref that added the rules_directory input and pass the renamed directory through it.
…r-activity-timeouts Lower the Pusher activity and pong timeouts from the SDK defaults
Auth and Web-Expensify pin the merge commit that added the rules_directory input. That tree is identical to the branch commit this workflow pinned, so adopt the shared SHA to give the three repositories one pin and one bump point.
…aude-review-rules-path [No QA] Point Claude review at the renamed coding standards rules
…o/beta-overrides-back-navigation Open beta overrides over the screen the test tools modal was opened from
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Fixed Issues
$
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari