Skip to content

Decompose MoneyRequestView into data hook and field components - #61

Closed
sosek108 wants to merge 703 commits into
mainfrom
refactor-money-request-view-decomposition
Closed

sosek108 wants to merge 703 commits into
mainfrom
refactor-money-request-view-decomposition

Conversation

@sosek108

Copy link
Copy Markdown

Explanation of Change

Decomposes MoneyRequestView into a data hook and per-field components:

  • src/components/ReportActionItem/MoneyRequestView/useMoneyRequestViewData.ts — all data derivation, Onyx reads, and press handlers for the expense detail view
  • src/components/ReportActionItem/MoneyRequestView/components/ — one component per field (Amount, Description, Merchant, Date, Category, Vendor, Tag, Card, Tax, Attendees, Reimbursable, Billable, Report, Trip, ViewTripDetails, PerDiemOutOfPolicyBanner, CompanyCardViolationMessage, DistanceRequestFields)
  • src/components/ReportActionItem/MoneyRequestView/types.ts — the MoneyRequestViewProps contract

The original MoneyRequestView.tsx is reduced to composing the extracted field components with no inline field logic. No behavior change — structural refactor for readability and render isolation. Also merges main, which migrated the "View trip details" navigation to dynamic routes (DYNAMIC_ROUTES.TRAVEL_TRIP_SUMMARY / TRAEL_TRIP_DETAILS) — ported into the extracted onViewTripDetailsPress handler. Includes lint fixes for the new files (alias imports, removed dead imports).

Fixed Issues

None
PROPOSAL:

Tests

  1. Open an expense (money request) from a report and verify all fields render exactly as before: receipt, amount, description, merchant, date, category, vendor, tag, card, tax rate, tax amount, attendees, reimbursable, billable, report, trip, and "View trip details" where applicable
  2. Edit the amount, description, merchant, date, category, vendor, and tax fields from the expense details — verify each edit flow opens and saves correctly
  3. Open a travel expense with multiple reservations, tap "View trip details" — verify it navigates to the trip summary and then to the trip details
  4. Open a per-diem expense with an out-of-policy rate — verify the out-of-policy banner renders
  5. Verify that no errors appear in the JS console

Offline tests

No network-related changes — all fields render from the same Onyx data as before; verify the expense details view renders correctly while offline.

QA Steps

Same as tests.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

cead22 and others added 30 commits August 24, 2026 17:56
Co-authored-by: Kevin Brian Bader <ikevin127@users.noreply.github.com>
Co-authored-by: Shawn Borton <shawnborton@users.noreply.github.com>
Co-authored-by: Shawn Borton <shawnborton@users.noreply.github.com>
…t reduction

Co-authored-by: Nyoman Jyotisa <nyomanjyotisa@users.noreply.github.com>
…mport ordering

Co-authored-by: Nyoman Jyotisa <nyomanjyotisa@users.noreply.github.com>
A time was formatted with date-fns under the app language while the picker that sets it labels its buttons from common.am/common.pm, so German read vorm. in one place and AM in another. Every render site now reads the same keys. The format/parse pair the picker round-trips through is untouched, and the marker is no longer derived by re-parsing a formatted string, which shifted an hour on the local DST change. Greek was also missing a dot on its PM marker.
handleEditFocus hardcoded forceKeyboardIfAlreadyFocused to true, so
leaving edit mode (Cancel or Save) also went through the forced path.
On iOS this tears down and rebuilds an already-visible keyboard via
KeyboardController.setFocusTo('current'), causing a one-frame flicker
in the report list ~150ms after exit. Only force it while entering
edit mode.
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
…r review

Co-authored-by: Shawn Borton <shawnborton@users.noreply.github.com>
Co-authored-by: Nyoman Jyotisa <nyomanjyotisa@users.noreply.github.com>
… closes

Co-authored-by: ahmedGaber93 <ahmedGaber93@users.noreply.github.com>
…tasks

Enqueue the onboarding OpenReport before the RequestExpensifyCardLimitIncrease write so Concierge's reply is stamped last, and make navigateToConciergeChat return a promise on every branch so the no-concierge-chat path can sequence the write after creation.

Co-authored-by: Maria D'Costa <MariaHCD@users.noreply.github.com>
JS00001 and others added 27 commits August 27, 2026 13:05
…CardLimitTypeValidityFlicker

Fix: Expensify Card validity dates flicker when changing Limit type
…useSingleExecution-Activity-fix

Reset execution state on unmount for Activity mode changes
…nk-account-status-not-shown

Show the new bank account statuses on Workflows for every workspace
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
…mistic-data

[No QA] log optimisticData for debugging
…mand-names

Send travel billing API command and param names
…/66425-part-15a

Part 15a - Thread delegateAccountID through the task-comment optimistic chain
…llingDocs

[No QA] Update billing-and-subscriptions help docs for the free Submit plan
…ion-message-name

[Phase 2] Part 3 - Migrate deprecatedGetReportName -> getReportName in ReportUtils libs
…toUpdateGovtRates

[No QA] Update help docs for Release 2: Auto-updating government rates
83207: debounce autocomplete query and memoize search options
refactor: remove unsafe Plaid connection assertions
…preview-metadata

Docs updates for E/A#96942 remove tag from expense preview details
…hlySettlementDate

Docs updates for E/A#98164 show Expensify Card monthly settlement date
…l-karma-native-91837

[No QA] Docs updates for E/A#97177 Personal Karma web-only, disabled in mobile app
…pts-search-98849

[No QA] Docs updates for E/A#98849 document bulk Download receipts in Search
…r-history

[No QA] Docs updates for E/A#98091 document View user history profile shortcut
# Conflicts:
#	src/components/ReportActionItem/MoneyRequestView.tsx
@coderabbitai

coderabbitai Bot commented Aug 28, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Comment @coderabbitai help to get the list of available commands.

@sosek108

Copy link
Copy Markdown
Author

Wrong repo — re-opened as a PR to Expensify/App

@sosek108 sosek108 closed this Aug 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.