Repository navigation
Conversation
Co-authored-by: Kevin Brian Bader <ikevin127@users.noreply.github.com>
Co-authored-by: Shawn Borton <shawnborton@users.noreply.github.com>
Co-authored-by: Shawn Borton <shawnborton@users.noreply.github.com>
…t reduction Co-authored-by: Nyoman Jyotisa <nyomanjyotisa@users.noreply.github.com>
…mport ordering Co-authored-by: Nyoman Jyotisa <nyomanjyotisa@users.noreply.github.com>
A time was formatted with date-fns under the app language while the picker that sets it labels its buttons from common.am/common.pm, so German read vorm. in one place and AM in another. Every render site now reads the same keys. The format/parse pair the picker round-trips through is untouched, and the marker is no longer derived by re-parsing a formatted string, which shifted an hour on the local DST change. Greek was also missing a dot on its PM marker.
handleEditFocus hardcoded forceKeyboardIfAlreadyFocused to true, so
leaving edit mode (Cancel or Save) also went through the forced path.
On iOS this tears down and rebuilds an already-visible keyboard via
KeyboardController.setFocusTo('current'), causing a one-frame flicker
in the report list ~150ms after exit. Only force it while entering
edit mode.
…ount-for-copilots
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
…r review Co-authored-by: Shawn Borton <shawnborton@users.noreply.github.com>
Co-authored-by: Nyoman Jyotisa <nyomanjyotisa@users.noreply.github.com>
…-expense-workspace-general-v2
… closes Co-authored-by: ahmedGaber93 <ahmedGaber93@users.noreply.github.com>
…tasks Enqueue the onboarding OpenReport before the RequestExpensifyCardLimitIncrease write so Concierge's reply is stamped last, and make navigateToConciergeChat return a promise on every branch so the no-concierge-chat path can sequence the write after creation. Co-authored-by: Maria D'Costa <MariaHCD@users.noreply.github.com>
…CardLimitTypeValidityFlicker Fix: Expensify Card validity dates flicker when changing Limit type
…useSingleExecution-Activity-fix Reset execution state on unmount for Activity mode changes
…nk-account-status-not-shown Show the new bank account statuses on Workflows for every workspace
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
…mistic-data [No QA] log optimisticData for debugging
…mand-names Send travel billing API command and param names
…/66425-part-15a Part 15a - Thread delegateAccountID through the task-comment optimistic chain
…llingDocs [No QA] Update billing-and-subscriptions help docs for the free Submit plan
…ion-message-name [Phase 2] Part 3 - Migrate deprecatedGetReportName -> getReportName in ReportUtils libs
…toUpdateGovtRates [No QA] Update help docs for Release 2: Auto-updating government rates
83207: debounce autocomplete query and memoize search options
refactor: remove unsafe Plaid connection assertions
…preview-metadata Docs updates for E/A#96942 remove tag from expense preview details
…hlySettlementDate Docs updates for E/A#98164 show Expensify Card monthly settlement date
…l-karma-native-91837 [No QA] Docs updates for E/A#97177 Personal Karma web-only, disabled in mobile app
…pts-search-98849 [No QA] Docs updates for E/A#98849 document bulk Download receipts in Search
…r-history [No QA] Docs updates for E/A#98091 document View user history profile shortcut
# Conflicts: # src/components/ReportActionItem/MoneyRequestView.tsx
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueComment |
Author
|
Wrong repo — re-opened as a PR to Expensify/App |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Decomposes
MoneyRequestViewinto a data hook and per-field components:src/components/ReportActionItem/MoneyRequestView/useMoneyRequestViewData.ts— all data derivation, Onyx reads, and press handlers for the expense detail viewsrc/components/ReportActionItem/MoneyRequestView/components/— one component per field (Amount, Description, Merchant, Date, Category, Vendor, Tag, Card, Tax, Attendees, Reimbursable, Billable, Report, Trip, ViewTripDetails, PerDiemOutOfPolicyBanner, CompanyCardViolationMessage, DistanceRequestFields)src/components/ReportActionItem/MoneyRequestView/types.ts— theMoneyRequestViewPropscontractThe original
MoneyRequestView.tsxis reduced to composing the extracted field components with no inline field logic. No behavior change — structural refactor for readability and render isolation. Also mergesmain, which migrated the "View trip details" navigation to dynamic routes (DYNAMIC_ROUTES.TRAVEL_TRIP_SUMMARY/TRAEL_TRIP_DETAILS) — ported into the extractedonViewTripDetailsPresshandler. Includes lint fixes for the new files (alias imports, removed dead imports).Fixed Issues
None
PROPOSAL:
Tests
Offline tests
No network-related changes — all fields render from the same Onyx data as before; verify the expense details view renders correctly while offline.
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari