Skip to content

Add DevDigest CI review - #33

Merged
burnjohn merged 1 commit into
mainfrom
devdigest/ci
Sep 10, 2026
Merged

burnjohn merged 1 commit into
mainfrom
devdigest/ci

Conversation

@burnjohn

@burnjohn burnjohn commented Sep 10, 2026 •

Copy link
Copy Markdown
Owner

This PR adds DevDigest's automated review (agents: General Reviewer, Spec Conformance Reviewer) as a GitHub Actions workflow. Add the OPENROUTER_API_KEY repository secret before merging so the workflow can run.

Summary by CodeRabbit

  • Improvements
    • Diff prompts now include new-file line numbers, making findings easier to locate.
    • Review summaries now present agent statuses, finding totals, and severity counts in a clearer, collapsible format.
    • Review submission handling avoids duplicate errors when an identical review was already posted.
  • Documentation
    • Finding fields now include clearer descriptions to improve interpretation of reported line ranges.

@coderabbitai

coderabbitai Bot commented Sep 10, 2026 •

Copy link
Copy Markdown

Review Change StackReview Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Advanced

Run ID: d940c044-9156-47bb-bda8-035558a9fc80

📥 Commits

Reviewing files that changed from the base of the PR and between 1d85e77 and 10b3c90.

📒 Files selected for processing (1)
  • .devdigest/runner/index.js

📝 Walkthrough

Walkthrough

The runner now numbers new-side diff lines for citation grounding, avoids duplicate failures after 5xx review-posting responses, and formats merged multi-agent findings with severity counts and collapsed sections.

Changes

Runner enhancements

Layer / File(s) Summary
Diff citation numbering
.devdigest/runner/index.js
The finding schema and prompt now use new-file line prefixes. numberDiffLines adds those prefixes while preserving diff structure.
Duplicate review handling
.devdigest/runner/index.js
After a 5xx posting response, the runner checks for an existing review with the exact body before returning or rethrowing.
Multi-agent review output
.devdigest/runner/index.js
Agent payloads include finding and severity counts. Merged reviews use updated headers, collapsed sections, and spacing. The registry records existing agents.

Estimated code review effort: 3 (Moderate) | ~20 minutes

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Warning

Some tools did not complete. Review the errors below.

🔧 ast-grep (0.45.3)
.devdigest/runner/index.js

ast-grep timed out on this file


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@burnjohn
burnjohn merged commit 19e7c3c into main Sep 10, 2026
2 of 3 checks passed

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DevDigest — 2 reviewers

✅ General Reviewer · ✅ Spec Conformance Reviewer

0 findings · 0 critical · 0 warning · 0 suggestion

No findings. Looks good.

✅ General Reviewer — 0 findings · 0 critical · 0 warning · 0 suggestion

General Reviewer — Approved ✅

No findings. Looks good.

✅ Spec Conformance Reviewer — 0 findings · 0 critical · 0 warning · 0 suggestion

Spec Conformance Reviewer — Approved ✅

No findings. Looks good.

@greptile-apps

greptile-apps Bot commented Sep 10, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 4/5

The PR appears safe to merge, with a non-blocking issue where a body-only fallback still directs users to nonexistent inline comments.

Findings

  1. P2 Fallback leaves misleading inline guidance ▶

Summary

  • Adds new-side line-number prefixes and citation guidance to review prompts.
  • Adds per-agent and aggregate finding counts with collapsible review details.
  • Checks for an already-created review after a GitHub 5xx response.
  • Extends CI preview metadata with existing reviewer names.

Reviews (1) · Last reviewed commit: "Update DevDigest CI configuration"

Comment on lines +36106 to +36107
findingsCount > 0
? '_Findings are posted as inline comments on the lines they refer to. Expand a reviewer below for its full list._'

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Fallback leaves misleading inline guidance

When GitHub rejects the inline review with 422, postGithubReview retries with only the body, but this text still directs users to inline comments that were removed from the retry payload.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant