Repository navigation
Keep schema hardlink rejection tests inside private fixtures - #4669
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The batch authority regression hardlinked the repository's full schema into its temporary output, changing the shared inode link count while other xdist workers validated authority. Copy the exact flattened schema into the private fixture and rebuild its registration before creating the alias. Both link endpoints are now fixture-owned; the real batch route still refuses the alias before planning, locking or execution.
The test checks inode separation before linking and verifies the original schema bytes and link count while the private alias exists and after rejection. An explicit flattened-schema precondition fails before linking if the schema gains imports. Production behavior and alias checks are unchanged.
Validation: independent adversarial review and evidence verification; 145 tests passed across batch authority, resource capture, schema synchronization, write footprints and output ownership (13 dependency deprecation warnings). Test source exactly matches commit
7aaf4be220b58e6d0e0eebcd248f5bc07d797427; retained JUnit SHA-256 is63cff815750373c9d5d2ed579951000ac50e044d11577b5673db24db61fa5022. An ignored/hidden-inclusive audit of the inspected hardlink calls found no other shared repository/package source alias in those forms.The concurrent timing in #4659 supports this defect as the omission acceptance failure explanation, but that failed record did not retain the offending inode. The separate native deadline failure remains unresolved; #4537/#4354/#4400 stay open.
Closes #4665