Repository navigation
Reuse decoded native streams and retain precise CI failure evidence - #4659
Open
realmarcin wants to merge 7 commits into
Open
realmarcin wants to merge 7 commits into
realmarcin wants to merge 7 commits into
Conversation
This was referenced Oct 8, 2026
This was referenced Oct 8, 2026
Refs #4677. Record initial focused failure without changing capture behavior.
Refs #4682; preserve all existing stream guards and original ValueError stop text.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracedecodes each captured stream twice during construction. This change reuses those decoded rows while preserving validation order and public behavior. It also isolates the shared-schema fixture, retains both synthetic native cases after CI teardown, and records the exact metadata associated with the first live-stream acquisition refusal.The new diagnostic records the selected stream, acquisition stage, offset, opened extent and sampled metadata without further reads. Its optional report field is detached from internal state. Existing refusal conditions, cursor-update timing,
ValueError-qualified first-stop text and acceptance limits remain unchanged; diagnostic serialization failure preserves the original refusal.This targets
review/4354-offline-acceptancefrom adapter0125eebbc214d0907c3b69d23758cd9441911a78; main does not contain this adapter. No persistent cache, cross-capture state or provider campaign is introduced.Validation:
d01ef23c37e22137be367a73f252cc74d4a58d73, including 26 new reader cases and 15 independent adversarial cases. These verify exact refusal metadata, immutable/detached report data, serialization fallback, unchanged cursor timing, no extra acquisition and refusal of later callbacks. All frozen controller dependency bytes are unchanged. The controls inject metadata schedules; they do not reproduce or diagnose the hosted failure.Integration remains blocked on required CI and complete native acceptance. The retained run at
aa845f2ehad two distinct failures: neutral stopped at 253.860 seconds on an equal-size/changed-mtime refusal, while omission reached the existing 900-second attempt deadline after sealing phase 1/core. The neutral artifact does not identify the exact sampled metadata pair or prove a race or rewrite; #4680 remains open. The original archives, matching JUnit, selected source bytes and reviewed standalone verifier are preserved in #4683. Prior deadline failures also remain documented.Capture and diagnostics do not change test selection, scheduling, helper behavior, admission or 900/180/120-second bounds. Fresh exact-head CI and independent case verification remain required. Scientific and provider-execution obligations are separate.
Closes #4675.
Closes #4677.
Closes #4682.
Refs #4537, #4354, #4400, #4680.