Skip to content

test(register-hook): take ports from the kernel instead of picking one at random #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bompus merged 1 commit into from
Oct 10, 2026
Merged

test(register-hook): take ports from the kernel instead of picking one at random #129

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions test/register-hook.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,14 @@ import { addT3V2Thread, createT3V2Tables } from "./fixtures/t3-v2-state.js";
import { parseTag, sessionTag } from "../src/tag.ts";
import { createServer } from "../src/server.ts";

/** A port nothing listens on yet, for a server that starts later in the test. */
function freePort() {
const probe = Bun.serve({ port: 0, fetch: () => new Response() });
const { port } = probe;
probe.stop(true);
return port;
}

/** A stand-in Swarmail MCP endpoint: `handler(tool, args)` returns the tool result and every call is recorded. */
function fakeMail(handler) {
const calls = [];
Expand Down Expand Up @@ -726,7 +734,7 @@ test("the hook registers under a fresh name when the server refuses the session'

test("a failed registration tells Claude, then the next prompt retries against the server and reports the name", async () => {
const dir = realpathSync.native(mkdtempSync(join(tmpdir(), "hook-retry-")));
const port = 20000 + Math.floor(Math.random() * 20000);
const port = freePort();
let server;
try {
const repo = join(dir, "repo");
Expand Down Expand Up @@ -790,8 +798,8 @@ test("a failed registration tells Claude, then the next prompt retries against t

test("a claude -p run registers on its first edit, not at start", async () => {
const dir = realpathSync.native(mkdtempSync(join(tmpdir(), "hook-headless-")));
const port = 20000 + Math.floor(Math.random() * 20000);
const server = createServer(join(dir, "mail.sqlite3"), port);
const server = createServer(join(dir, "mail.sqlite3"), 0);
const port = server.server.port;
try {
const repo = join(dir, "repo");
Bun.spawnSync(["git", "init", "-q", repo]);
Expand Down Expand Up @@ -843,8 +851,8 @@ test("a claude -p run registers on its first edit, not at start", async () => {

test("a session registers at start, keeps that one name through edits, restarts and hand registration", async () => {
const dir = realpathSync.native(mkdtempSync(join(tmpdir(), "hook-start-")));
const port = 20000 + Math.floor(Math.random() * 20000);
const server = createServer(join(dir, "mail.sqlite3"), port);
const server = createServer(join(dir, "mail.sqlite3"), 0);
const port = server.server.port;
try {
const repo = join(dir, "repo");
Bun.spawnSync(["git", "init", "-q", repo]);
Expand Down
Loading