Repository navigation
test(register-hook): take ports from the kernel instead of picking one at random - #129
Merged
Merged
Conversation
…e at random Two tests picked a random port in 20000-40000 and started a server there, so a busy port failed the run with EADDRINUSE (seen on PR #128's first CI run). They now bind port 0; the test that starts its server late asks the kernel for a free port first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two register-hook tests picked a random port in 20000-40000 and started a server there. A busy port failed the run with
EADDRINUSE, which happened once on PR #128's first CI run (the rerun passed).Those two tests now bind port 0 and read the assigned port. The test that must start its server after a first failed attempt asks the kernel for a free port before it starts.
Checked:
bun test test/register-hook.test.jsthree times (28 pass each) andbun run check.Summary by CodeRabbit