Skip to content

Prepare environment to allow account creation into the database - #2824

Open
ArnyminerZ wants to merge 15 commits into
mainfrom
2820-allow-creating-accounts-into-the-database
Open

Prepare environment to allow account creation into the database#2824
ArnyminerZ wants to merge 15 commits into
mainfrom
2820-allow-creating-accounts-into-the-database

Conversation

@ArnyminerZ

@ArnyminerZ ArnyminerZ commented Aug 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Organizational

Important

Please make sure an issue or discussion for this change exists and was acknowledged by the
core team before submitting. Uncoordinated pull requests may conflict with the project roadmap
and could be closed without merging — which would be a pity.
See CONTRIBUTING.md for details.

  • An issue or discussion that proposes this change exists and was acknowledged by the core team.
    (The PR is still welcome otherwise, but could be closed at any time without much attention
    when it doesn't fit.)

✨ AI contributions – only check if applicable:

  • This PR and its concept was mainly driven by a human. This does not apply when an issue
    is just referenced/copied into an AI prompt and then the result is submitted as PR.

PRs that are mainly driven by AI often have little worth, as everybody could just copy the issue
into a prompt. The worth of a good PR often comes from the main idea, architectural decisions etc.
behind it. So while all PRs are welcome, such PRs may be reviewed with less human attention and closed
at any time when they don't fit.

Purpose

Short description

  • Extend DbAccountDao's operations
  • Add a new getAllValues function to the settings store.
    It's used for extracting all the data stored in an account settings.
    Use case: first insert all initial data into the database of user settings, then copy it directly to user data

Checklist

  • The PR has a proper title, description and label.
  • I have self-reviewed the PR.
  • I have added documentation to complex functions and functions that can be used by other modules.
  • I have added reasonable tests or consciously decided to not add tests.

@ArnyminerZ ArnyminerZ linked an issue Aug 18, 2026 that may be closed by this pull request
Allow creating accounts into the database #2820
Closed
@ArnyminerZ
ArnyminerZ force-pushed the 2820-allow-creating-accounts-into-the-database branch 2 times, most recently from a2152c5 to af025f9 Compare August 18, 2026 19:47
@ArnyminerZ ArnyminerZ changed the title 2820 allow creating accounts into the database Prepare environment to allow account creation into the database Aug 18, 2026
@ArnyminerZ
ArnyminerZ marked this pull request as ready for review August 18, 2026 20:19
@ArnyminerZ ArnyminerZ self-assigned this Aug 19, 2026
@ArnyminerZ
ArnyminerZ requested a review from sunkup August 19, 2026 07:30
@ArnyminerZ ArnyminerZ linked an issue Aug 19, 2026 that may be closed by this pull request
AccountRepository: support DB accounts (in addition to legacy accounts) #2039
Open
2 tasks
sunkup
sunkup approved these changes Aug 19, 2026
View reviewed changes

@sunkup sunkup left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

@ArnyminerZ
ArnyminerZ force-pushed the 2820-allow-creating-accounts-into-the-database branch 3 times, most recently from c583158 to fb55112 Compare August 20, 2026 08:17
ArnyminerZ and others added 15 commits August 20, 2026 12:25
@ArnyminerZ
Add the required DAO operations
724f9a3 
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
@ArnyminerZ
Add getAllValues
0f3b4a2 
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
@ArnyminerZ
Add putInitialSettings which initializes settings for an account
336d680 
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
@ArnyminerZ
Add the required DAO operations
7e8c0c9 
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
@ArnyminerZ
Add the required DAO operations
70266c3 
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
@ArnyminerZ
Implement getAllValues for InMemorySettingsStore
1ef242e 
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
@ArnyminerZ
Use insertBlocking
e0c890e 
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
@ArnyminerZ
Optimize functions
6bf6fcd 
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
@ArnyminerZ
Implement ids for workers
3e138d2 
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
@ArnyminerZ
Update required DAO operations
8047e1e 
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
@ArnyminerZ
Add getAllValues
ae49290 
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
@ArnyminerZ
Add putInitialSettings which initializes settings for an account
4758951 
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
@ArnyminerZ
Implement getAllValues for InMemorySettingsStore
a2c9189 
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
@ArnyminerZ
Optimize functions
5f67cca 
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
@ArnyminerZ @claude
Remove stray duplicate resource/*.kt files reintroduced by rebase
68f656d 
These files were already moved to resource/local/ on main; the rebase
onto main recreated stale pre-move copies at the old path for some of
this branch's commits, leaving dead duplicates.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@ArnyminerZ
ArnyminerZ force-pushed the 2820-allow-creating-accounts-into-the-database branch from fb55112 to 68f656d Compare August 20, 2026 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sunkup sunkup sunkup approved these changes

Assignees

@ArnyminerZ ArnyminerZ

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AccountRepository: support DB accounts (in addition to legacy accounts) Allow creating accounts into the database

2 participants

@ArnyminerZ @sunkup