feat: download the json schemas from the signal-cli releases - #869
Merged
Conversation
40 tasks
Owner
|
Thanks a lot! |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR downloads the json schemas from signal-cli releases instead of compiling them. This is possible now that AsamK/signal-cli#2040 is merged and that a new signal-cli release is out that publishes it (v0.14.6).
I tested this by building the image for the current signal cli version and but using 0.14.6 for the schema generation step.
Apologies for the extra work that you had to do to remove the downloading the schemas from my fork from the original PR.