Repository navigation
fix(ci): count the Compare command and check the inventory when commands change - #1468
Conversation
…nds change compare_paths_left_out reached main in #1450 without the inventory: the CLI smoke job that compares the two does not run on a change to lib.rs alone, so the drift surfaced later, on the next pull request that touches a provider, whatever that pull request did. Regenerate the snapshot and run the job on lib.rs, build.rs, which derives the command list from it, and the snapshot itself. Session: L1 91583d13 Signed-off-by: axpnet <45786925+axpnet@users.noreply.github.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Record the command in the inventory docs/COMMAND-INVENTORY.json |
The inventory adds compare_paths_left_out. The Tauri command count changes from 793 to 794, and the unmatched-name count changes from 327 to 328. |
Extend CLI smoke workflow triggers .github/workflows/cli-smoke.yml |
The push and pull request path filters add src-tauri/src/lib.rs, src-tauri/build.rs, and docs/COMMAND-INVENTORY.json. |
Estimated code review effort: 1 (Trivial) | ~5 minutes
Change: Bug fix
Possibly related PRs
- axpdev-lab/aeroftp#1450: Adds and registers
compare_paths_left_out; this pull request records the command and adds workflow triggers for related paths. - axpdev-lab/aeroftp#1466: Records
compare_paths_left_outin the same command inventory.
Merge Risk: 
d2331
-
The command inventory and smoke-workflow triggers are consistent with the intended update. No actionable merge-blocking risk was identified; merge after normal checks pass.
Pre-merge checks: 
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title clearly describes both main changes: adding the Compare command to the inventory and triggering inventory checks when command-related files change. Docstring Coverage No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Problem
docs/COMMAND-INVENTORY.jsonon main lists 793 Tauri commands, the code registers 794. #1450 addedcompare_paths_left_outand did not regenerate the snapshot.The CLI smoke job compares the two, but its path filter does not include
src-tauri/src/lib.rs, so #1450 never ran it. The failure then lands on the next pull request that touches a provider or the CLI, whatever that pull request changed. It is failing that way on #1462 and #1463, and #1466 and #1459 each carry their own copy of this fix.Change
aeroftp-cli inventorybuilt from this base. The diff is the one command: the two list entries and the three counts.src-tauri/src/lib.rs,src-tauri/build.rs(it derives the command list fromlib.rs) anddocs/COMMAND-INVENTORY.json, so a pull request that adds a command meets the check itself.Verification
aeroftp-cli inventory --check docs/COMMAND-INVENTORY.jsonpasses locally.No application code changes.
Summary by CodeRabbit