Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Classic maps can lose filename-derived tiling after unloading and reloading from a temporary save. Neighboring tiles then disappear and map edges become impassable; resetting the map temporarily restores the links by loading the original source.
Implementation / behavior
Rebuild filename-derived links when loading celestial temporary maps, before validating their headers. Share the existing derivation with the original-map loader while preserving explicit tile paths, boundary policies, and
MAP_NO_DYNAMIC.Clean up links established by rejected headers and unlink reciprocal neighbor pointers only when they belong to the map being freed.
Regression fixtures exercise horizontal and vertical links, resident and swapped neighbors, reciprocal pointers, edge traversal, saved mutable objects, explicit overrides, and serialization. Failure-path coverage checks that rejected reloads leave no dangling neighbor links.
Validation
classic-build:1.16.0CPU worker; fenced wrapperbuild server --test: 61/61 tests passed.git diff --checkpassed.Limitations / follow-up
Orion's documented SSH target was unreachable from the development workspace, so live gameplay confirmation remains outstanding. This PR changes source only; it does not deploy or reset the live server.