Repository navigation
feat: save region-map exploration per account - #556
Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
Security findingsAdvisory findings (2)
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 632ac7b054
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
🛡️ Codex Security Review · Automatically triggered
Here are some automated security review suggestions for this pull request.
Reviewed commit: 632ac7b054
ℹ️ About Codex security reviews in GitHub
This is an experimental Codex feature. Security reviews are triggered when:
- You comment "@codex security review"
- A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review
Once complete, Codex will leave suggestions, or a comment if no findings are found.
|
@codex review |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
There was a problem hiding this comment.
🛡️ Codex Security Review · Automatically triggered
Here are some automated security review suggestions for this pull request.
Reviewed commit: c612b82f43
ℹ️ About Codex security reviews in GitHub
This is an experimental Codex feature. Security reviews are triggered when:
- You comment "@codex security review"
- A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review
Once complete, Codex will leave suggestions, or a comment if no findings are found.
Preserve account exploration alongside current rendering, recording, and checked shutdown behavior. Propagate exploration sidecar save failures before administrative shutdown completion and cover active and detached account failures with regression tests.
|
@codex review |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Keep builds, tests, GPU coverage execution and TLS verification required. Treat external Codecov report-processing failures as non-blocking, as approved. Validation: 44 workflow contract tests, actionlint, import history, whitespace, and independent review passed.
Preserve access-code authentication and exploration with distinct protocol commands. Fix output queue accounting for sensitive access packets and cover mixed producers.
Resolve the CI workflow conflict by preserving main's informational Codecov reporting.
1 participant
Summary
Save region-map exploration on the server per account so all characters share discoveries and a fresh client restores that progress.
Closes #549.
Implementation / behavior
Validation
e2ba0c31eb162756645f011d8cb135baff4b23ec.e2ba0c31eb162756645f011d8cb135baff4b23ec.Limitations / follow-up
Old per-character
client-maps/*.tilesfiles remain untouched and are not imported. Exact-version negotiation requires protocol 1082 on both peers. An abrupt crash can lose the most recent five-second unsaved server batch. Full account saves are linear in the stored bitfields and occur only at persistence boundaries. Large client exploration histories appear progressively over frames; records beyond the client bitmap limit are rejected without evicting accepted discoveries.The persistence, wire bounds, ownership and cache contract is documented in
server/doc/REGION_EXPLORATION.md.