Repository navigation
glm cuda: test-glm-snapshots-host's copies module imports core, which cuda_snaps.zig reads for TF_GLM_PROMPT_TAIL - #2403
Conversation
|
Thanks @Bizuayeu, a clean find. Main's step can't build because One optional follow-up, if you'd like it: |
Thanks. Yes, I'll send that as its own pull request once this one lands: the snapshots run joins the family's aggregate |
… cuda_snaps.zig reads for TF_GLM_PROMPT_TAIL
94ec9c4 to
68d641e
Compare
|
Thank you @Bizuayeu. This is merged into main with your commits under your own name, so you're listed as a TensorFold contributor. It ships in the next release, credited to you in the changelog and the release notes. |
What this changes
zig build test-glm-snapshots-hosthas not built since #2226:fc8bd41edhascuda_snaps.zigreadTF_GLM_PROMPT_TAILthrough@import("core").profile, and the step'scopiesmodule, made inzig/build/glm_family_host.zig, importsengine_apialone ("no module named 'core' available within module'copies'"). The module now imports
coretoo, as the step's other modules do. No source file changes. CI does not runthis step, so the break did not show there.
5a45539af; it merges cleanly with519136dd9, where glm: the config parser reads quantization_config inside text_config too, as EXL3 admission does #2327 has landed since.atc overlap --json: at 2026-11-06 22:27 UTC, on this head against main5a45539af: glm cuda: EXL3 mcg experts at any whole-bit width, mixed by projection #2094 and glm cuda: TF_GLM_GRAPHS=1 replays verify windows as CUDA graphs (#1490) #2279 overlap andmerge cleanly, no conflicts; incomplete (
invalidPulls,otherPullRequestsLimit,pullFilesUnavailable,timeLimit).Checks on this head
94ec9c4a8python3 tools/zig/lean_check.py, on the base and on this head: 155 and 155 problems, none new.zig build test-glm-snapshots-host4/4 steps (21 of 21tests) on this head; on main
5a45539afit stops at compile with the error above. With CI's flags,zig build -Dfixed-cpu test548/548 steps (7,395 of 7,456 tests, 61 skipped).zig fmt --check build.zig zig.zig,zig-windows,zig-macos-dev-tools,release-paths,fmtand bothbenchmark-clients).Receipt
n/a: a build file's module imports for a host test step; it cannot reach inference.
Checklist
step's 21 tests build and pass again.)