Skip to content

glm cuda: test-glm-snapshots-host joins test-cuda-host, as the family's other host steps do - #2426

Open
Bizuayeu wants to merge 2 commits into
ashhart:mainfrom
Bizuayeu:pr/glm-snaps-aggregate
Open

Bizuayeu wants to merge 2 commits into
ashhart:mainfrom
Bizuayeu:pr/glm-snaps-aggregate

Conversation

@Bizuayeu

@Bizuayeu Bizuayeu commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

What this changes

test-glm-snapshots-host was the one GLM host step left out of test-cuda-host: its run was wired only to its own step
in zig/build/glm_family_host.zig, so zig build test never built it, and the break from #2226 stayed red on main
until #2403 (#2095 lists it among the steps red on main, under #2031). The run now also joins the family's aggregate
with step.dependOn, as the family's other host steps do, so CI builds it and runs its 21 tests. Its host-cache test
declared libc's setenv and unsetenv itself, which Windows' C library lacks, so the zig-windows job failed to link
it; it now sets TF_GLM_HOST_CACHE through sys.env, as cuda_snaps.zig's own test does.

Checks on this head

  • Head commit: b04769ece
  • Lean checker, python3 tools/zig/lean_check.py, on the base and on this head: 116 and 116 problems, none new.
  • Tests run, with the command and pass, fail and skip counts: zig build test-cuda-host 327/327 steps (5,332 of 5,357
    tests, 25 skipped) on this head and 325/325 steps (5,311 of 5,336 tests, 25 skipped) on main 1b58f2e98; with CI's
    flags, zig build -Dfixed-cpu test 561/561 steps (7,647 of 7,708 tests, 61 skipped) on this head and 559/559 steps
    (7,626 of 7,687 tests, 61 skipped) on main. The 21 more in each are the snapshots run's.
    zig fmt --check build.zig zig.
  • CI: all seven checks pass on this head (zig, zig-windows, zig-macos-dev-tools, release-paths, fmt and both
    benchmark-clients), and both zig and zig-windows run the snapshots tests in zig build -Dfixed-cpu test (their
    GLM snapshot sizing lines are in both logs). On the first head, 0790b76d0, zig-windows failed to link them
    (setenv, unsetenv); the second commit fixes that.
  • Not run, and why: the GPU suites, which a build file's list of host steps does not reach; Windows, which only CI's
    zig-windows job runs here.

Receipt

n/a: a build file's list of host test steps; it cannot reach inference.

Checklist

  • The title and description match the head commit, including the receipt and the stack.
  • New tests fail before the change, pass after it, and skip cleanly without their dependency. (No new tests: the
    step's 21 tests now run under test-cuda-host and test.)
  • Comments and docstrings are one line. No measurements or history in the source.
  • No personal data, machine names, internal hosts or local paths in the diff or its commits. No AI attribution lines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant