Repository navigation
Conversation
…'s other host steps do
… sys.env, so test-cuda-host links on Windows
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
test-glm-snapshots-hostwas the one GLM host step left out oftest-cuda-host: its run was wired only to its own stepin
zig/build/glm_family_host.zig, sozig build testnever built it, and the break from #2226 stayed red on mainuntil #2403 (#2095 lists it among the steps red on main, under #2031). The run now also joins the family's aggregate
with
step.dependOn, as the family's other host steps do, so CI builds it and runs its 21 tests. Its host-cache testdeclared libc's
setenvandunsetenvitself, which Windows' C library lacks, so thezig-windowsjob failed to linkit; it now sets
TF_GLM_HOST_CACHEthroughsys.env, ascuda_snaps.zig's own test does.glm cuda: test-glm-snapshots-host's copies module imports core, which cuda_snaps.zig reads for TF_GLM_PROMPT_TAIL #2403 (comment). ci: collect native Linux host checks and guard exclusions #2095's
test-hostwould reach the step too;with glm cuda: test-glm-snapshots-host's copies module imports core, which cuda_snaps.zig reads for TF_GLM_PROMPT_TAIL #2403 in, its exclusion entry for this step can go. This PR leaves ci: collect native Linux host checks and guard exclusions #2095's list alone.
1b58f2e98, with glm cuda: test-glm-snapshots-host's copies module imports core, which cuda_snaps.zig reads for TF_GLM_PROMPT_TAIL #2403 in.atc overlap --json: at 2026-11-07 06:47 UTC, on this head against main9b15a958d: glm cuda: EXL3 mcg experts at any whole-bit width, mixed by projection #2094 and glm cuda: TF_GLM_GRAPHS=1 replays verify windows as CUDA graphs (#1490) #2279 overlap andmerge cleanly, no conflicts; incomplete (
pullFilesUnavailable,timeLimit). glm cuda: a chat's next turn can resume at the previous turn's history (opt-in, #2396) #2404, which adds a step beside thisone in
glm_family_host.zig, merges with it cleanly in that file (git merge-tree).Checks on this head
b04769ecepython3 tools/zig/lean_check.py, on the base and on this head: 116 and 116 problems, none new.zig build test-cuda-host327/327 steps (5,332 of 5,357tests, 25 skipped) on this head and 325/325 steps (5,311 of 5,336 tests, 25 skipped) on main
1b58f2e98; with CI'sflags,
zig build -Dfixed-cpu test561/561 steps (7,647 of 7,708 tests, 61 skipped) on this head and 559/559 steps(7,626 of 7,687 tests, 61 skipped) on main. The 21 more in each are the snapshots run's.
zig fmt --check build.zig zig.zig,zig-windows,zig-macos-dev-tools,release-paths,fmtand bothbenchmark-clients), and bothzigandzig-windowsrun the snapshots tests inzig build -Dfixed-cpu test(theirGLM snapshot sizinglines are in both logs). On the first head,0790b76d0,zig-windowsfailed to link them(
setenv,unsetenv); the second commit fixes that.zig-windowsjob runs here.Receipt
n/a: a build file's list of host test steps; it cannot reach inference.
Checklist
step's 21 tests now run under
test-cuda-hostandtest.)