Repository navigation
kernel contract: tf_ctl_pocket_in_fmax's closing brace, lost when MOSS-Image's CUDA controls landed inside it - #1769
Closed
BobClawblaw wants to merge 1 commit into
Closed
BobClawblaw wants to merge 1 commit into
BobClawblaw wants to merge 1 commit into
Conversation
…S-Image's CUDA controls landed inside it contract_controls.cu stopped compiling with nvcc at 12eaec9 (namespace definition is not allowed), so every CUDA build of tf-cuda-test failed.
This was referenced Oct 31, 2026
Open
Contributor
Author
|
Superseded by fbbc20d, which makes the same one-brace fix on main. Closing. |
This was referenced Oct 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
zig/kernels/cuda/contract_controls.cuhasn't compiled with nvcc since 12eaec9 (#1528), so every CUDA build oftf-cuda-testfails:When #1528 landed, its MOSS-Image controls went in between the last two lines of
tf_ctl_pocket_in_fmax, and the block's final}took the place of the function's own. #1528's pushed head (11cf033) had the block after the EXL3 controls and compiled. The macOS checks don't build this file, so CI stayed green.This puts the brace back, one line. Nothing else changes: the MOSS block is byte for byte the one in #1528's head.
Checked on an RTX 5090 (sm_120, nvcc 13.3): main with this commit builds
tf-cuda-testandtf-moss-image. The same commit on top of #1687 and #1632 builds too and passestest-cuda-hoston both, and #1687'stf-moss-imagegives MOSS-Image's 512 fox case latents byte-identical to main's. Mac: fmt and lean clean (0 new).