Skip to content

Issue forms and a sharper pull request template - #1596

Draft
jayleaton wants to merge 1 commit into
ashhart:mainfrom
jayleaton:repo/issue-pr-templates
Draft

jayleaton wants to merge 1 commit into
ashhart:mainfrom
jayleaton:repo/issue-pr-templates

Conversation

@jayleaton

@jayleaton jayleaton commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

What this changes

Before: reporters filed blank issues or free-form text, and the pull request template asked for a receipt but not for the issue link, the stack or an overlap check. After: four issue forms (bug, performance, proposal, feature) ask for the version, checkpoint revision, hardware and the exact command or request, config.yml turns blank issues off, and .github/pull_request_template.md gains Issue, Stacked on, atc overlap --json and Checks on this head, with the kernel contract collapsed into a details block.

Why: reproducible reports, and a description a reviewer can act on without asking for the same pieces twice. Each field traces to CONTRIBUTING.md or to a survey of the 100 newest pull requests and 80 newest issues.

  • Issue: n/a. Repository housekeeping offered to the maintainer; no issue tracks it.
  • Stacked on: main. A pull request skill for contributor agents #1595 (the pull request skill) stacks on this branch and adds only docs/pr/SKILL.md, AGENTS.md and README.md.
  • atc overlap --json (ATC 0.7.0, against main): no conflict on any of the six files. ATC returned complete: false with pullFilesLimit, so treat the result as partial; the only other pull request whose commits touch these files is A pull request skill for contributor agents #1595, which stacks on this branch.

Checks on this head

  • Head commit: 8ae1990
  • Lean checker, python3 tools/zig/lean_check.py, on the base (465e48b62) and on this head: 425 and 425, 0 new (tools/zig/lean_new.py). Both runs exit 1 on the 425 findings already on main.
  • Tests run, with the command and pass, fail and skip counts:
    • yaml.safe_load on all five files: 5 passed, 0 failed, 0 skipped.
    • jsonschema Draft 7 against SchemaStore's github-issue-forms.json and github-issue-config.json: 5 passed, 0 failed, 0 skipped.
    • git diff --check: clean.
  • CI: 9/9 checks pass on this head (fmt, zig, zig-windows, zig-macos-dev-tools, appimage-linux, desktop, desktop-linux, mobile, release-paths); no failure.
  • Not run locally, and why: no Zig build or zig fmt here, because the diff is six files under .github/ and touches no Zig source, build input or test; CI's zig job ran the host suite on this head.

Receipt

n/a: issue-form metadata and a pull request template cannot reach inference.

Checklist

  • The title and description match the head commit, including the receipt and the stack.
  • New tests fail before the change, pass after it, and skip cleanly without their dependency. (none added; the schema checks above are the check)
  • Comments and docstrings are one line. No measurements or history in the source.
  • No personal data, machine names, internal hosts or local paths in the diff or its commits. No AI attribution lines.

The pull request template asks for the issue link, the atc overlap result,
the lean checker's base and head counts and the paths and platforms reached.
Its receipt and inference checklist now say "n/a" for changes that cannot
reach inference, the kernel contract is a section only kernel changes fill,
and new weights or drafters state their licence.

Issue forms for bugs, performance regressions, feature requests and the
issue-first proposal for a model family, backend or arithmetic change ask for
the version or commit, the checkpoint and revision, the hardware and the exact
command. Blank issues are off; contact links point to CONTRIBUTING, the agent
radar, the known issues and the runbook.
@ashhart

ashhart commented Oct 30, 2026

Copy link
Copy Markdown
Owner

Thanks for the issue forms and the template update. Could you add a short description, and say whether #1595 is meant to stack on this one? Right now both PRs add the same six files, so we'll land one as the base and rebase the other on it.

@jayleaton

Copy link
Copy Markdown
Contributor Author

Added a short description with the checks and a stacking note: #1595 is stacked on this PR, so merge this one first and #1595 then adds only docs/pr/SKILL.md, AGENTS.md and README.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants