Repository navigation
Conversation
The pull request template asks for the issue link, the atc overlap result, the lean checker's base and head counts and the paths and platforms reached. Its receipt and inference checklist now say "n/a" for changes that cannot reach inference, the kernel contract is a section only kernel changes fill, and new weights or drafters state their licence. Issue forms for bugs, performance regressions, feature requests and the issue-first proposal for a model family, backend or arithmetic change ask for the version or commit, the checkpoint and revision, the hardware and the exact command. Blank issues are off; contact links point to CONTRIBUTING, the agent radar, the known issues and the runbook.
4 tasks done
Owner
|
Thanks for the issue forms and the template update. Could you add a short description, and say whether #1595 is meant to stack on this one? Right now both PRs add the same six files, so we'll land one as the base and rebase the other on it. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Before: reporters filed blank issues or free-form text, and the pull request template asked for a receipt but not for the issue link, the stack or an overlap check. After: four issue forms (bug, performance, proposal, feature) ask for the version, checkpoint revision, hardware and the exact command or request,
config.ymlturns blank issues off, and.github/pull_request_template.mdgainsIssue,Stacked on,atc overlap --jsonandChecks on this head, with the kernel contract collapsed into a details block.Why: reproducible reports, and a description a reviewer can act on without asking for the same pieces twice. Each field traces to
CONTRIBUTING.mdor to a survey of the 100 newest pull requests and 80 newest issues.docs/pr/SKILL.md,AGENTS.mdandREADME.md.atc overlap --json(ATC 0.7.0, against main): no conflict on any of the six files. ATC returnedcomplete: falsewithpullFilesLimit, so treat the result as partial; the only other pull request whose commits touch these files is A pull request skill for contributor agents #1595, which stacks on this branch.Checks on this head
python3 tools/zig/lean_check.py, on the base (465e48b62) and on this head: 425 and 425, 0 new (tools/zig/lean_new.py). Both runs exit 1 on the 425 findings already on main.yaml.safe_loadon all five files: 5 passed, 0 failed, 0 skipped.github-issue-forms.jsonandgithub-issue-config.json: 5 passed, 0 failed, 0 skipped.git diff --check: clean.fmt,zig,zig-windows,zig-macos-dev-tools,appimage-linux,desktop,desktop-linux,mobile,release-paths); no failure.zig fmthere, because the diff is six files under.github/and touches no Zig source, build input or test; CI'szigjob ran the host suite on this head.Receipt
n/a: issue-form metadata and a pull request template cannot reach inference.
Checklist