Skip to content

A pull request skill for contributor agents - #1595

Draft
jayleaton wants to merge 2 commits into
ashhart:mainfrom
jayleaton:repo/pr-skill
Draft

jayleaton wants to merge 2 commits into
ashhart:mainfrom
jayleaton:repo/pr-skill

Conversation

@jayleaton

@jayleaton jayleaton commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

What this changes

Before: contributor agents had no procedure for preparing a pull request, and maintainers kept asking for the same missing pieces. After: docs/pr/SKILL.md (tensorfold-pull-request) is a pre-flight an agent runs before gh pr create. Its §3 and §7 map each step to a line of the revised template. AGENTS.md and README#contributing-with-agents point to it.

docs/pr/SKILL.md   new, 125 lines
  1 Scope, issue and coordination   -> Issue, Stacked on, atc overlap
  2 Base and head                   -> Head commit, Stacked on, checklist line 1
  3 Fill the template               template section -> skill step; delete only what the template says to delete
  4 Kernels, arithmetic, platforms  -> Kernel contract section, Paths and platforms
  5 Tests and checks                -> Lean, Tests run, CI, Not run
  6 Hygiene                         -> checklist hygiene lines
  7 Final self-check                only what the template checklist does not already ask
AGENTS.md, README.md   +1 line each

Each rule comes from CONTRIBUTING.md, the kernel contract or the ATC skill, plus a recent survey of 100 PRs. This change doesn't touch .github/.

Checks on this head

  • Head commit: 542857cfe226228b9768c2e2c8a37bdb32224661
  • Lean checker, run on the merge base and on this head with the same checker as CI: lean: 425 problems, 425 on the base, 0 new. The 425 come from the base tree.
  • Tests run:
    • Every relative link and anchor in docs/pr/SKILL.md, AGENTS.md and README.md resolves (script check).
    • git diff --check is clean.
    • The skill's kernel commands match docs/kernel-contract.md and the code. CUDA limits come from tf-cuda-test kernel-contract-limits DIR (zig/tests/cuda/main.zig), and hip-kernel-contract-limits is a zig build step (zig/build/hip_contract.zig).
  • CI: fmt passes; the other workflows have not started (fork workflows wait for approval).
  • Not run: the Zig host suite and zig fmt, because no Zig source changed. No workflow runs a markdown check on docs.

Receipt

n/a: this is documentation and cannot reach inference.

Checklist

  • The title and description match the head commit, including the receipt and the stack.
  • New tests fail before the change, pass after it, and skip cleanly without their dependency. (none added)
  • Comments and docstrings are one line. No measurements or history in the source.
  • No personal data, machine names, internal hosts or local paths in the diff or its commits. No AI attribution lines.

The pull request template asks for the issue link, the atc overlap result,
the lean checker's base and head counts and the paths and platforms reached.
Its receipt and inference checklist now say "n/a" for changes that cannot
reach inference, the kernel contract is a section only kernel changes fill,
and new weights or drafters state their licence.

Issue forms for bugs, performance regressions, feature requests and the
issue-first proposal for a model family, backend or arithmetic change ask for
the version or commit, the checkpoint and revision, the hardware and the exact
command. Blank issues are off; contact links point to CONTRIBUTING, the agent
radar, the known issues and the runbook.
Add docs/pr/SKILL.md, a pre-flight an agent runs before opening a pull
request: scope and issue link, ATC overlap, rebase, the receipt, kernel
and arithmetic gates, tests and lean delta, hygiene and a final check.
Point to it from AGENTS.md and the README agent workflow.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant