editor: New thread opens the what-to-build screen, never an empty thread - #500
Merged
Merged
Conversation
New thread asked the Forge to create a "New task" thread up front, and mounting it replaced the new-thread screen with an empty thread showing "No messages yet". It now retires the open thread and shows the new-thread screen on the project's new-task draft; the Forge creates the thread when that draft is sent, which the screen already supported. Typed text still follows into the new task; an empty composer shows the project's saved draft instead of replacing it. The "No messages yet" overlay is gone: a conversation with no turns shows nothing, and the new-thread screen owns the empty prompt. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Clicking New thread landed on an empty thread titled "New task" that said "No messages yet." instead of the "What should we build in editor?" screen.
begin_new_tasksentCreateTask, and mounting the created thread navigated the new-thread route to it.What
begin_new_taskno longer creates a thread. It retires the open thread (subscription stop), binds the composer to the project's new-task draft (ComposerDraftScope::Project) and shows the new-thread screen. The Forge creates the thread when the draft is sent, using the existing project-draft send flow (#83457dbf).Tests
Rewrote the tests that asserted
CreateTask(new-thread retirement, project choice from new-thread/existing/home, initially empty project, desktop new task). They now assert: no thread is created, the source stops, the route is NewThread on the project draft, the draft is kept, and Send is available.cargo test -p artisan-frontend --lib: 776 passed, 2 failed.work_group_header_row_paints_without_a_disclosure_wrapperandsend_has_stable_identity…fail identically on master without this change.🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Clicking New thread now opens the "What should we build in editor?" screen instead of an empty thread that showed "No messages yet." No thread is created up front; the Forge creates it when the draft is sent, and the currently open thread is retired first.
Written for commit e221050. Summary will update on new commits.