feat: search assistant messages and mark named sessions#8
Merged
Conversation
Two search/topic UX gaps from the codebase review: - The list filter only matched user messages, but the HITS column and preview highlighting already counted all messages - so a conversation was unfindable by something only Claude said, while the UI implied it was searchable. buildItems now includes assistant text in searchText (and searchLower), making the filter consistent with HITS/preview. - Named sessions (custom/ai title) and rows that fall back to the first user message looked identical in the TOPIC column. Named rows now get a leading ✎ marker so a curated name is distinguishable from a truncated opening line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two search/topic UX gaps from the codebase review.
1. Assistant messages weren't searchable
The list filter matched user messages only, but the HITS column and preview highlighting already counted all messages including Claude's. So a conversation was unfindable by something only Claude said (a root-cause explanation, code Claude wrote, an error it quoted), even though the HITS count and
>>>preview markers implied it was searchable.buildItemsnow includes assistant text insearchText(and the precomputedsearchLower), so the filter agrees with HITS/preview.2. Named sessions looked identical to first-message rows
Since #3, the TOPIC column shows the session name (custom / AI title) when present, else the first user message. Both rendered the same, so you couldn't tell a curated name ("Refactor auth flow") from a truncated opening line ("hey can you look at this bug where…"). Named rows now get a leading ✎ marker.
Notes
searchText/searchLowerper conversation; bounded by--max-age/--max-sizeas before.truncateis rune-safe (from fix: render multibyte text without corrupting UTF-8 #4).Tests
TestBuildItemsnow asserts assistant text is insearchText(would fail under the old user-only code).TestFormatListItemNamedSessionMarker- named row shows ✎, first-message fallback does not.go test -cover= 69.0%.