fix: only mark user-set custom titles, not auto ai-titles#13
Merged
Conversation
The ✎ marker showed whenever a conversation had any Title, but Claude auto-generates an ai-title for almost every session (215 of 225 files here), so the marker appeared on nearly every row - implying everything was a named session. Track whether the title came from a user-set custom-title and show the marker only for those. ai-titles still display as the topic text (real session names instead of first messages), just without the marker, so ✎ now means "you named this".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The ✎ marker (added in #8) was meant to flag named sessions, but it showed whenever a conversation had any
Title. Claude auto-generates anai-titlefor almost every session - 215 of 225 files here have one, only 12 have a user-setcustom-title- so the marker appeared on ~96% of rows, implying everything was specially named.Fix
Track
IsCustomTitle(true only when the title came from a user-setcustom-title) and show the ✎ only for those.ai-titles still display as the TOPIC text - that's the useful part, real session names instead of first messages - just without the marker. So ✎ now honestly means "you named this".Tests
TestParseConversationFileAiTitleNotCustom- an ai-title setsTitlebut leavesIsCustomTitlefalse.TestParseConversationFileTitle- a custom-title setsIsCustomTitletrue.TestFormatListItemNamedSessionMarker- marker shows for custom, not for ai-title, not for first-message fallback.go test -cover= 70.9%.Note
Touches the
Conversationstruct andformatListItem, which the open size-column PR (#12) also touches on nearby lines - they edit different lines so should merge cleanly, but I'll rebase whichever lands second.