Skip to content

[Fix]: 온보딩 테스트 컴파일 에러 및 ktlint 위반 수정 #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oungsi2000 merged 1 commit into from
Aug 24, 2026
+13 −6
Merged

[Fix]: 온보딩 테스트 컴파일 에러 및 ktlint 위반 수정 #163

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion feature/onboarding/src/main/java/com/kikidan/onboarding/OnboardingViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,12 @@ class OnboardingViewModel
reduce { state.copy(submitState = OnboardingSubmitState.Success) }
postSideEffect(OnboardingSideEffect.PermissionRequest)
}.onFailure { e ->
reduce { state.copy(submitState = OnboardingSubmitState.Failure, step = OnboardingStep.EXTRA_QUESTION) }
reduce {
state.copy(
submitState = OnboardingSubmitState.Failure,
step = OnboardingStep.EXTRA_QUESTION,
)
}
postSideEffect(OnboardingSideEffect.Failure(e))
}
}
Expand Down
12 changes: 7 additions & 5 deletions feature/onboarding/src/test/java/com/kikidan/onboarding/OnboardingViewModelTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import com.kikidan.onboarding.model.OnboardingSheet
import com.kikidan.onboarding.model.OnboardingSideEffect
import com.kikidan.onboarding.model.OnboardingState
import com.kikidan.onboarding.model.OnboardingStep
import com.kikidan.onboarding.model.OnboardingSubmitState
import kotlinx.coroutines.Dispatchers
import kotlinx.coroutines.ExperimentalCoroutinesApi
import kotlinx.coroutines.test.StandardTestDispatcher
Expand Down Expand Up @@ -159,8 +160,9 @@ class OnboardingViewModelTest {
)
viewModel().test(this, initialState = initial) {
containerHost.confirmComplete(onboardingToken)
expectState { copy(isSubmitting = true, step = OnboardingStep.COMPLETE) }
expectState { copy(isSubmitting = false, step = OnboardingStep.COMPLETE) }
expectState { copy(submitState = OnboardingSubmitState.Loading, step = OnboardingStep.COMPLETE) }
expectState { copy(submitState = OnboardingSubmitState.Success, step = OnboardingStep.COMPLETE) }
expectSideEffect(OnboardingSideEffect.PermissionRequest)
}
}

Expand All @@ -177,7 +179,7 @@ class OnboardingViewModelTest {
birthTime = BirthTime.JA,
lifeStage = Job.STUDENT,
relationshipStatus = RelationshipStatus.SOLO,
isSubmitting = true,
submitState = OnboardingSubmitState.Loading,
)
viewModel().test(this, initialState = initial) {
containerHost.confirmComplete(onboardingToken)
Expand All @@ -204,8 +206,8 @@ class OnboardingViewModelTest {
)
viewModel().test(this, initialState = initial) {
containerHost.confirmComplete(onboardingToken)
expectState { copy(isSubmitting = true, step = OnboardingStep.COMPLETE) }
expectState { copy(isSubmitting = false, step = OnboardingStep.EXTRA_QUESTION) }
expectState { copy(submitState = OnboardingSubmitState.Loading, step = OnboardingStep.COMPLETE) }
expectState { copy(submitState = OnboardingSubmitState.Failure, step = OnboardingStep.EXTRA_QUESTION) }
expectSideEffect(OnboardingSideEffect.Failure(error))
}
}
Expand Down
Loading