[Fix]: 온보딩 테스트 컴파일 에러 및 ktlint 위반 수정 - #163
Merged
Merged
Conversation
OnboardingState의 isSubmitting 필드가 submitState(OnboardingSubmitState)로 바뀐 이후 OnboardingViewModelTest가 갱신되지 않아 develop 빌드의 lint-and-test가 컴파일 에러로 실패하고 있었다. 테스트를 현재 상태 모델에 맞게 수정하고, 성공 경로에서 함께 발생하는 PermissionRequest 사이드이펙트 검증을 추가했다. 같은 파일의 ktlintMainSourceSetCheck 위반도 함께 정리. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015do5t4ThrkmdyfYb4gkbCq
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
관련 이슈
작업 내용
develop 브랜치의 CI(lint-and-test)가 실패하고 있던 문제 수정
변경사항 / 상세
OnboardingState.isSubmitting필드가submitState: OnboardingSubmitState?로 바뀐 이후OnboardingViewModelTest가 갱신되지 않아 컴파일 에러(No parameter with name 'isSubmitting' found)로 테스트 빌드가 실패하던 문제 수정isSubmitting = true/false참조를submitState = OnboardingSubmitState.Loading/Success/Failure로 교체PermissionRequest사이드이펙트 검증 추가 (turbineUnconsumed events방지)OnboardingViewModel.kt의ktlintMainSourceSetCheck위반(줄바꿈/라인 길이) 정리중점 리뷰사항
submitState/step전이가OnboardingViewModel.confirmComplete의 실제 로직과 일치하는지스크린샷 (선택)
🤖 Generated with Claude Code